Skip to content

Conversation

@ArnyminerZ
Copy link
Member

Purpose

There are some deprecations with aboutlibs. Also we should be using the M3 version.

Short description

  • Switched to M3
  • Fixed usage of LibrariesContainer to the new non-deprecated method involving rememberLibraries.
  • Replaced some deprecated usages in gradle.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ self-assigned this Jun 2, 2025
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Jun 2, 2025
@ArnyminerZ ArnyminerZ requested review from Copilot and sunkup June 2, 2025 17:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses deprecations in the AboutLibs dependency and migrates usage to the M3 version.

  • Update the dependency in libs.versions.toml to use the M3 version.
  • Modify InfoActivity.kt to replace deprecated APIs with the new rememberLibraries API and adjust the LibrariesContainer call accordingly.
  • Update the Gradle DSL in build.gradle.kts to match the new AboutLibs configuration API.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
gradle/libs.versions.toml Changed the module dependency to the new M3 version.
app/src/main/java/at/bitfire/icsdroid/ui/InfoActivity.kt Updated imports and usage to utilize the new rememberLibraries API.
app/build.gradle.kts Migrated to the updated DSL for AboutLibs configuration.

sunkup
sunkup previously approved these changes Jun 3, 2025
@sunkup sunkup merged commit f401b1b into dev Jun 3, 2025
7 checks passed
@sunkup sunkup deleted the aboutlibs-deprecation branch June 3, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants