Skip to content

Conversation

@ArnyminerZ
Copy link
Member

Purpose

Fix #695

Short description

Followed the same approach as updateSubscription, to call onExit when the job is done.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue Sep 11, 2025 that may be closed by this pull request
@ArnyminerZ ArnyminerZ requested a review from Copilot September 11, 2025 11:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes issue #695 by ensuring the EditSubscriptionScreen exits after subscription removal, matching the existing behavior for subscription updates.

  • Modified removeSubscription() to return a Job that can be awaited
  • Updated the delete button handler to call onExit() after the removal completes
  • Reorganized import order for consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
EditSubscriptionScreen.kt Updated delete handler to exit screen after removal and fixed import ordering
EditSubscriptionModel.kt Modified removeSubscription() to return a Job for completion tracking

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArnyminerZ ArnyminerZ requested a review from sunkup September 11, 2025 11:03
@ArnyminerZ ArnyminerZ marked this pull request as ready for review September 11, 2025 11:03
@ArnyminerZ ArnyminerZ self-assigned this Sep 11, 2025
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Sep 11, 2025
@sunkup sunkup added this to the 2.4.2 milestone Sep 11, 2025
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ~

@ArnyminerZ ArnyminerZ merged commit 9489669 into dev Sep 12, 2025
7 checks passed
@ArnyminerZ ArnyminerZ deleted the 695-edit-subscription-screen-does-not-close-on-unsubscribe branch September 12, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit subscription screen does not close on unsubscribe

2 participants