Event builders: use VEvent instead of deprecated Event as input
#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unknownProperties() method to filter known properties - Update test for unknown properties handling - Refactor KNOWN_PROPERTY_NAMES to include processed properties
rfc2822
changed the title
VEvent instead of deprecated Event as input
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the calendar mapping code to work directly with VEvent (ical4j native components) instead of the deprecated Event data class. This is a significant architectural change that modernizes the codebase by removing an abstraction layer and working more directly with the iCalendar library's native types.
Key changes:
- Replace all
Eventusages withVEventin builder classes and tests - Update property access from direct field access to ical4j's property-based API
- Migrate from
Event.exceptionstoAssociatedEventsstructure - Remove deprecated
Eventtest file and move tests to appropriate builder test files
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AndroidEventBuilder.kt |
Renamed from LegacyAndroidEventBuilder2, now accepts AssociatedEvents instead of Event |
| Builder classes (20+ files) | Updated build() signatures from Event to VEvent, changed property access patterns |
| Test files (25+ files) | Migrated test data from Event constructor to VEvent with propertyListOf() helper |
ICalendar.kt |
Refactored vAlarmToMin() to accept individual date properties instead of Event/Task objects |
Event.kt |
Removed organizerEmail property, increased deprecation level to WARNING |
EventTest.kt |
Deleted - tests moved to AttendeesBuilderTest.kt |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/builder/RecurrenceFieldsBuilder.kt
Show resolved
Hide resolved
lib/src/main/kotlin/at/bitfire/synctools/mapping/calendar/builder/AvailabilityBuilder.kt
Show resolved
Hide resolved
rfc2822
deleted the
69-event-builders-change-input-class-from-event-to-vevent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the builders and the tests so that they direclty use the ical4j
VEventclass instead of the deprecatedEventdata class.Also closes #100.