Skip to content

Add logging for timezone normalization mismatches#227

Merged
rfc2822 merged 2 commits intoical4j-3to4from
normalizedate-log-warning
Mar 13, 2026
Merged

Add logging for timezone normalization mismatches#227
rfc2822 merged 2 commits intoical4j-3to4from
normalizedate-log-warning

Conversation

@rfc2822
Copy link
Member

@rfc2822 rfc2822 commented Mar 12, 2026

  • Log warning when normalized ZonedDateTime has different timestamp than original (as suggested by @cketti, could really improve debugging in verbose logs)
  • Add test case for TZID known to system but with different VTIMEZONE
  • Improve error message for unknown timezone cases

- Log warning when normalized ZonedDateTime has different timestamp than original
- Add test case for TZID known to system but with different VTIMEZONE
- Improve error message for unknown timezone cases
@rfc2822 rfc2822 self-assigned this Mar 12, 2026
@rfc2822 rfc2822 marked this pull request as ready for review March 12, 2026 20:16
- Replace generic timezone assertions with specific ZonedDateTime comparisons
- Change test timezone from Europe/Vienna to Europe/Berlin for consistency
- Update DTSTART TZID in test iCalendar data to match new timezone
@rfc2822 rfc2822 requested a review from cketti March 12, 2026 20:25
Copy link
Contributor

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rfc2822 rfc2822 merged commit 4c10d6a into ical4j-3to4 Mar 13, 2026
4 checks passed
@rfc2822 rfc2822 deleted the normalizedate-log-warning branch March 13, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants