Fix R8 build errors after updating to ical4j 4.x#337
Merged
Conversation
4 tasks
rfc2822
approved these changes
May 7, 2026
Member
|
I'll merge so that I can create a new APK for testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #335
Purpose
Fix R8 build errors after updating to ical4j 4.x.
Short description
This is assuming we don't want to use the optional caffeine caching library that ical4j uses for timezone caching.
The unresolved references come from
com.github.benmanes.caffeine.**ical4j - Optional caching library. We have timezone cache configured to useMapTimeZoneCachein ical4j.propterties so safe to ignore.org.joda.convert.ToString: threeten-extra (@ToStringannotation) - I assume that is safe to ignore.java.time.zone.ZoneRulesProvider: Runtime support for java.time is provided through desugaring which can lead to a different class path than R8 might expect during static analysis. I think ignoring is safe because DAVx5’s has desugaring enabled.Checklist