Skip to content

Fix R8 build errors after updating to ical4j 4.x#337

Merged
rfc2822 merged 1 commit into
mainfrom
335-update-cache-config-r8-for-ical4j-4x-2
May 7, 2026
Merged

Fix R8 build errors after updating to ical4j 4.x#337
rfc2822 merged 1 commit into
mainfrom
335-update-cache-config-r8-for-ical4j-4x-2

Conversation

@sunkup
Copy link
Copy Markdown
Member

@sunkup sunkup commented May 7, 2026

Closes #335

Purpose

Fix R8 build errors after updating to ical4j 4.x.

Short description

This is assuming we don't want to use the optional caffeine caching library that ical4j uses for timezone caching.

The unresolved references come from

  • com.github.benmanes.caffeine.** ical4j - Optional caching library. We have timezone cache configured to use MapTimeZoneCache in ical4j.propterties so safe to ignore.
  • org.joda.convert.ToString: threeten-extra (@ToString annotation) - I assume that is safe to ignore.
  • java.time.zone.ZoneRulesProvider: Runtime support for java.time is provided through desugaring which can lead to a different class path than R8 might expect during static analysis. I think ignoring is safe because DAVx5’s has desugaring enabled.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup sunkup linked an issue May 7, 2026 that may be closed by this pull request
@sunkup sunkup self-assigned this May 7, 2026
@sunkup sunkup added the pr-bugfix Fixes something that isn't working (only used for PRs) label May 7, 2026
@sunkup sunkup requested a review from rfc2822 May 7, 2026 07:13
@sunkup sunkup marked this pull request as ready for review May 7, 2026 07:13
@rfc2822
Copy link
Copy Markdown
Member

rfc2822 commented May 7, 2026

I'll merge so that I can create a new APK for testing

@rfc2822 rfc2822 merged commit cf85330 into main May 7, 2026
9 checks passed
@rfc2822 rfc2822 deleted the 335-update-cache-config-r8-for-ical4j-4x-2 branch May 7, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Fixes something that isn't working (only used for PRs)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cache config / R8 for ical4j 4.x

2 participants