Fix back-reference index in AndroidCalendar.addEvent #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify `addEvent` method in `AndroidCalendar` to use the correct back-reference index for event rows. - Update `withValueBackReference` function to include documentation about proper usage.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in batch event insertion where back-references to newly inserted events were incorrectly hardcoded to index 0, causing issues when the event wasn't the first operation in the batch.
- Changed
addEventto usebatch.nextBackrefIdx()instead of hardcoded index 0 for back-references - Added comprehensive test coverage for batch operations where the event insertion is not the first operation
- Updated comments to improve clarity around event row insertion and data row references
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AndroidCalendar.kt | Fixed back-reference index calculation and improved comment clarity |
| BatchOperation.kt | Added documentation for the withValueBackReference method |
| AndroidCalendarTest.kt | Added test case for event insertion as second batch operation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rfc2822
deleted the
58-androidcalendaraddevent-assumes-that-it-always-writes-the-first-event-of-a-batch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes batch event insertion with back-references when the inserted event is not the first in the batch.
testAddEvent_toBatch_AsSecondOperationinAndroidCalendarTest.ktto verify that events can be inserted as the second operation in a batch and that back-references are handled correctly.addEventinAndroidCalendarto usebatch.nextBackrefIdx()when adding an event, ensuring that sub-values (such as reminders) correctly reference the newly inserted event row, regardless of its position in the batch.