verify: port FileLock XTC/TRR test fix from MDAnalysis#5423#1
Open
bitflicker64 wants to merge 3 commits into
Open
verify: port FileLock XTC/TRR test fix from MDAnalysis#5423#1bitflicker64 wants to merge 3 commits into
bitflicker64 wants to merge 3 commits into
Conversation
Port of MDAnalysis#5423 (orbeckst) for independent CI verification. - filelock >= 3.29.5 keeps lockfiles on POSIX (avoids race); update test + xfail older - Windows runners now remove lockfile after release; assert accordingly - Expand XDR offsets / FileLock docs and intersphinx mapping Fixes verification of MDAnalysis#5382
Upstream jobs only run when github.repository == MDAnalysis/mdanalysis. Allow bitflicker64/mdanalysis so this fork can exercise the MDAnalysis#5423 port. - Open linter + GH Actions CI job gates to this fork - Add focused fork-verify-filelock workflow for offset lock tests - Skip IMD tests on the fork only (imdclient 0.2.4 hangs; unrelated)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent verification of MDAnalysis/mdanalysis#5423 by @orbeckst (Oliver Beckstein).
Ports the same XDR FileLock test/docs changes so fork CI can exercise them.
Upstream people on MDAnalysis#5423
Review comment on upstream: MDAnalysis#5423 (comment)
Changes
test_offset_lock_createdforfilelock >= 3.29.5(POSIX keeps lockfile)Test plan
Upstream issue: MDAnalysis/mdanalysis#5382