Incorrect use of action to set custom variable causes companion to lock-up

[champagj]

Describe the bug
When using internal: Set custom variable value instead of internal: Set custom variable expression action to set a value with an expression, companion locks up.

I incorrectly chose set value to update a custom variable with an expression

To Reproduce
Create a custom variable: jf_segment
Create a button to increment the value of jf_segment by 1
Select Action internal: Set custom variable value with Value $(internal:custom_jf_segment) + 1
Press button.
Companion is frozen

Expected behavior
While this is caused by user error, it is fairly likely to happen as the actions are similar and relate to similar functions
The section on getting-started#3-custom-variables mentions that invalid expressions would be ignored.
Similar test/check should be done on value set to ensure they are valid as well

Screenshots

Environment
Companion Pi 2.2.0 running built 3694

[krocheck]

@champagj are you able to get at the console to get a readout on the error? I tried to reproduce on Win and it simply set the value of the variable as expected to the plain text. There's a try-catch on action execution intentionally as a catch all for potential edge cases like this, so its unclear at face value what's going on here (at least to me).

[champagj]

@krocheck when you say console, do you mean the log with debug selected?

I ran the test again and captured the log. Offending button is 1.8 and did not even register on the log before locking up.

Log (debug mode)

I also open an ssh session with the Raspberry Pi but there is no verbose there..
I am not sure where else to go to get a console output, if someone can help me out here, I'll do the test again.

Thanks,

[krocheck]

@champagj Understood. Via SSH are you running using the yarn headless command? Running yarn dev-headless will give you a verbose output.

[champagj]

@champagj Understood. Via SSH are you running using the yarn headless command? Running yarn dev-headless will give you a verbose output.

No I am not using yarn headless command to launch companion.
I did a manual install method as per the wiki. Companion is running as a service and auto-run at boot. Looking at the .service file I guess that the launch command would be:
node /home/pi/companion/headless_ip.js 0.0.0.0
But this command only does not work directly via SSH

I can stop the service/companion via SSH and then I get companion to start verbose with yarn dev-headless but does not bind to an interface and does not load config. I tried a few different commands / options to get the debug output but no success.
I need a bit of help to manually launch companion via SSH in dev mode..

[Julusian]

@krocheck Ive just given this a try and all the output I get is:

  lib/action Running action {
  id: 'wIeknG-tZ',
  label: 'bitfocus-companion:custom_variable_set_value',
  instance: 'bitfocus-companion',
  action: 'custom_variable_set_value',
  options: { name: 'aaaa', value: '$(internal:custom_aaaa) +1' },
  delay: 0
} +0ms
  lib/variable Set value "aaaa":$(internal:custom_aaaa) +1 +5s
  lib/variable Variable $(internal:custom_aaaa) is "$(internal:custom_aaaa) +1" +0ms
  lib/bank variable changed in bank 1.27 +2ms
  lib/server_tcp bank_bg send to all open sockets {"type":"bank_bg_change","page":1,"bank":27,"red":0,"green":0,"blue":0} +2ms

Yeah, its getting lost in an infinite inside of 'variable_parse' replacing the variable with itself..

I think we need to completely rethink the logic inside of 'variable_parse' to avoid infinite loops. But this may 'break' some functionality...

[krocheck]

Yeah, I see it. I'm thinking we have an array to store the keys in as they're parsed and check each key to see if it comes through a 2nd time.

[Julusian]

Hopefully this will be resolved without side effects in #1867