Fix new layout issues in Boilerplate (#10038)

[msynk]

closes #10038

Summary by CodeRabbit

• Style

  • Enhanced header spacing for a more balanced layout.
  • Improved main layout responsiveness with updated panel and content padding.
  • Adjusted the loading indicator overlay for clearer visual layering.

• New Features

  • Updated navigation behavior to automatically close the panel on identity pages.
  • Refined menu display rules so the About option is shown only under specific conditions.
  • Removed web view details from the About page for a cleaner presentation.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request introduces several updates across layout styling and component logic. In the stylesheets, a new padding rule has been added to the header and existing layout classes have been reintroduced or modified. In the C# files, conditional checks in route handling and navbar logic have been refined, with additional state changes applied. Moreover, the loading component’s z-index value has been reduced, and the About page has been simplified by removing web view information. No public API declarations were altered.

Changes

File(s)	Change Summary
.../Header.razor.scss	Added padding: 0.5rem to the header selector.
.../MainLayout.razor.cs	Modified SetRouteData to use pattern matching for identity check and set isNavPanelOpen to false for identity pages.
.../MainLayout.razor.scss	Reintroduced the .panel class and updated the .body class with new padding values (1rem and 4.5rem for media queries).
.../NavBar.razor	Changed the conditional directive from an OR to an AND condition for displaying the "About" nav option.
.../LoadingComponent.razor.cs	Updated the z-index assignment from "999999" to "999" during the initial render.
.../AboutPage.razor .../AboutPage.razor.cs	Removed the display and assignment of web view information from the About page.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MainLayout
    participant IdentityCheck
    User->>MainLayout: Navigate to page
    MainLayout->>IdentityCheck: Evaluate identity (using pattern matching)
    IdentityCheck-->>MainLayout: Return true/false
    alt Identity page
        MainLayout->>MainLayout: Set isNavPanelOpen = false
    else Non-identity page
        MainLayout->>MainLayout: Maintain current navigation state
    end
    MainLayout->>User: Render page

Loading

sequenceDiagram
    participant NavBar
    participant Condition
    NavBar->>Condition: Check (module != "Admin" && sample != true)
    alt Condition met
        Condition-->>NavBar: Render "About" option
    else Condition not met
        Condition-->>NavBar: Skip rendering "About" option
    end

Loading

Poem

I'm a rabbit with a code-hop beat,
Adding padding and changing routes so neat.
The panels and nav now flow in line,
Z-index trimmed, web info confined.
With each change, my spirit leaps high—
Happy coding under a bright blue sky! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/Header.razor.scss (1)

8-10: Consider consolidating padding properties

The new padding: 0.5rem; property overlaps with the existing padding-block: 0.5rem; property. In CSS, later properties take precedence, so this results in:

• Top/bottom padding: 0.5rem (from padding-block)
• Left/right padding: 0.5rem (from padding)

For better maintainability, consider consolidating these into a single property.

-    padding: 0.5rem;
-    padding-block: 0.5rem;
+    padding: 0.5rem;

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/MainLayout.razor.scss (1)

12-12: Minor Structure Separation Improvement
The inserted separation after the media query block helps improve the file’s visual organization.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4b3bf3 and edf8d3b.

📒 Files selected for processing (7)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/Header.razor.scss (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/MainLayout.razor.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/MainLayout.razor.scss (3 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/NavBar.razor (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/LoadingComponent.razor.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Components/Pages/AboutPage.razor (0 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Components/Pages/AboutPage.razor.cs (0 hunks)

💤 Files with no reviewable changes (2)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Components/Pages/AboutPage.razor
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/Components/Pages/AboutPage.razor.cs

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (6)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/LoadingComponent.razor.cs (1)

32-32: Reduced z-index value looks good

Reducing the z-index from a very high value to 999 is a good practice. This still ensures the loading component appears above normal content while using a more reasonable value in the stacking context hierarchy.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/NavBar.razor (1)

18-18: Logical condition change for About page visibility

The condition has been changed from OR to AND logic, which will show the About page option in fewer scenarios. Now the option will only appear when both conditions are met (module is not "Admin" AND sample is not true), rather than when either condition was met previously.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/MainLayout.razor.cs (2)

163-163: Improved conditional check using pattern matching

Using pattern matching with is true is a modern approach that makes the boolean check more explicit and readable.

---

166-166: Auto-closing nav panel on identity pages

Adding this behavior ensures a better user experience by automatically closing the navigation panel when users navigate to identity pages, which typically require focused attention.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Layout/MainLayout.razor.scss (2)

51-62: Reintroduced .panel Class in Identity Layout
The new .panel class is defined with a width of 70% and height set to 100%, which properly complements the .body (30% width) in the identity layout. The use of flexbox properties (display: flex, align-items: center, justify-content: center) and the media query to hide the panel on smaller screens are well implemented.

---

85-96: Updated .body Styles in Non-Identity Layout
The changes in the non-identity layout’s .body—specifically setting the width and height to 100%, applying a padding of 1rem, and updating the bottom padding to 4.5rem under the lt-md media query—align with the PR’s objective to improve spacing and responsiveness. Please verify that these new padding values and overall styling achieve the intended layout design across devices.