Fix issues of persist feature of BlazorUI theme (#10059)

[msynk]

closes #10059

Summary by CodeRabbit

• Refactor
  • Improved the internal configuration processing to enhance maintainability without affecting user functionality.

[coderabbitai]

Walkthrough

The changes reorder the processing logic within the BitTheme class’s init method. The persist option's check is moved to a later point in the method while the options object initialization is restructured to place the system attribute above the persist attribute. No alterations were made to the declarations of any exported or public entities. Overall functionality remains unchanged.

Changes

File(s)	Change Summary
src/BlazorUI/.../Theme/bit-theme.ts	Reordered the persist option handling in the init method and adjusted the options object initialization by moving system above persist. Functionality is preserved.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant InitMethod as BitTheme.init
    participant PersistCheck as "Persist Option Logic"
    participant OptionsInit as "Options Initialization"

    Caller->>InitMethod: Call init()
    InitMethod->>PersistCheck: Process persist option (later in flow)
    PersistCheck-->>InitMethod: Return persist state
    InitMethod->>OptionsInit: Initialize options (system before persist)
    OptionsInit-->>InitMethod: Options set up complete

Loading

Poem

I'm the bunny of code, so light and fleet,
Hoping through logic with quick, nimble feet.
I re-arranged my hops in a brand new way,
With persist and system in a prancing ballet.
Code carrots and bugs, oh what a delightful play!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e21aa92 and 8d3faa3.

📒 Files selected for processing (1)

• src/BlazorUI/Bit.BlazorUI/Utils/Theme/bit-theme.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (2)

src/BlazorUI/Bit.BlazorUI/Utils/Theme/bit-theme.ts (2)

33-36: Logical fix: Persist option now properly overrides system/default themes.

Good change! Moving the persist option check after the system/default checks ensures that user's persisted theme preference takes precedence, which is the expected behavior for user preferences.

---

85-87: Improved code organization.

Reordering the options properties to match their processing sequence in the init method improves code readability and maintainability.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.