Skip to content

maintain return-url during email confirmation re-send in Boilerplate (#10083)#10084

Merged
msynk merged 1 commit intobitfoundation:developfrom
yasmoradi:10083
Feb 27, 2025
Merged

maintain return-url during email confirmation re-send in Boilerplate (#10083)#10084
msynk merged 1 commit intobitfoundation:developfrom
yasmoradi:10083

Conversation

@yasmoradi
Copy link
Member

@yasmoradi yasmoradi commented Feb 27, 2025

closes #10083

Summary by CodeRabbit

  • New Features
    • Enhanced the email confirmation process so that after confirming their account, users are now redirected to the intended page automatically.

@yasmoradi yasmoradi requested a review from msynk February 27, 2025 19:35
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

The changes update the email confirmation flow by including an additional parameter for a return URL. On the client side, the ResendEmailToken method in the ConfirmPage now passes both the email and a return URL. On the server side, the IdentityController receives this return URL (via request.ReturnUrl) instead of a null value. Additionally, the shared DTO for sending the email token has been enhanced with a new nullable property, ReturnUrl, to transmit this extra data.

Changes

File(s) Change Summary
.../ConfirmPage.razor.cs
.../IdentityController.EmailConfirmation.cs
Updated the SendConfirmEmailToken method calls to include a ReturnUrl parameter (using ReturnUrlQueryString on the client and request.ReturnUrl on the server) instead of a null value.
.../SendEmailTokenRequestDto.cs Added a new nullable property ReturnUrl to the DTO, expanding the data structure for token requests.

Sequence Diagram(s)

sequenceDiagram
    participant CP as ConfirmPage
    participant IC as IdentityController

    CP->>IC: SendConfirmEmailToken({ Email, ReturnUrl })
    Note over CP,IC: Request now includes a return URL parameter
    IC-->>CP: Return confirmation response
Loading

Poem

Hopping through code with a joyful beat,
I’ve tweaked the flow to keep it neat.
Added a ReturnUrl for tokens so clear,
Each line and call now brings us cheer.
I'm the rabbit, coding with a carrot and a happy heart! 🐰


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9a48f0 and 1f4a9ac.

📒 Files selected for processing (3)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/ConfirmPage.razor.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.EmailConfirmation.cs (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Dtos/Identity/SendEmailTokenRequestDto.cs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build and test
🔇 Additional comments (3)
src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Dtos/Identity/SendEmailTokenRequestDto.cs (1)

11-12: Clean addition of the ReturnUrl property

The addition of the nullable ReturnUrl property is a simple and appropriate change that aligns with the PR objective of maintaining the return URL during email confirmation re-sending.

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Controllers/Identity/IdentityController.EmailConfirmation.cs (1)

22-22: Properly passing the ReturnUrl from the request

The change appropriately passes the ReturnUrl from the request DTO to the SendConfirmEmailToken method, which already has fallback logic for null values in line 69: returnUrl ??= Urls.HomePage;. This ensures the user will be directed to the correct page after confirmation.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Identity/ConfirmPage.razor.cs (1)

102-102: ReturnUrl properly passed during email token resend

This change correctly passes the ReturnUrlQueryString as the ReturnUrl property in the SendConfirmEmailToken request. The implementation is consistent with how the return URL is used in other parts of the component (like in the ConfirmEmail and ConfirmPhone methods).

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msynk msynk changed the title maintain reuturn-url during email confirmation re-send in Boilerplate (#10083) maintain return-url during email confirmation re-send in Boilerplate (#10083) Feb 27, 2025
@msynk msynk merged commit b98e452 into bitfoundation:develop Feb 27, 2025
3 checks passed
@yasmoradi yasmoradi deleted the 10083 branch March 1, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boilerplate resend email confirmation is not maintaining return-url

2 participants