Improve bit boilerplate external dependencies codes (#12130)#12131
Improve bit boilerplate external dependencies codes (#12130)#12131yasmoradi merged 1 commit intobitfoundation:developfrom
Conversation
WalkthroughThe PR updates Aspire-related package versions to 13.1.2 and Microsoft.Agents.AI to 1.0.0-rc2, modifies database admin UIs to use default configurations, refines storage health check logic, adds Redis connection logging, and updates test documentation. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves external dependencies in the bit Boilerplate template by updating Aspire packages to version 13.1.2, fixing documentation references, reducing logging noise from Redis, and improving the storage health check implementation.
Changes:
- Updated all official Aspire packages from 13.1.1 to 13.1.2 for better compatibility and bug fixes
- Fixed documentation comments to reference correct test class names (UITests and IntegrationTests instead of IdentityTests)
- Added Redis connection logging configuration to reduce noise in logs
- Improved storage health check to use ListAsync instead of ExistsAsync for better reliability across storage providers
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TestsAssemblyInitializer.cs | Added using statement for test classes referenced in XML documentation comments and corrected class names in comments |
| appsettings.json | Added logging configuration for StackExchange.Redis.ConnectionMultiplexer across all environments to reduce log noise |
| AppPlatform.cs | Removed misleading comment stating Linux is not supported (it is supported for Android development) |
| Program.cs | Simplified database admin tool volume configurations by removing custom paths |
| Boilerplate.Server.AppHost.csproj | Updated Aspire.AppHost.Sdk from 13.1.1 to 13.1.2 |
| AppStorageHealthCheck.cs | Changed health check from ExistsAsync to ListAsync for more reliable folder existence verification |
| Directory.Packages.props | Updated all official Aspire packages to 13.1.2 and Microsoft.Agents.AI to 1.0.0-rc2 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Infrastructure/Services/AppStorageHealthCheck.cs`:
- Around line 18-22: The health check in AppStorageHealthCheck currently calls
blobStorage.ListAsync(settings.UserProfileImagesDir) which can throw when the
profile-images directory doesn't exist and incorrectly mark storage unhealthy;
fix by first checking existence (use a dedicated exists method on the storage
interface if available) or handle the specific "not found" /
DirectoryNotFoundException/FileNotFoundException from blobStorage.ListAsync and
treat that case as healthy (only treat other exceptions as unhealthy), so update
the health-check logic around blobStorage.ListAsync and
settings.UserProfileImagesDir to detect/mask a missing folder rather than
failing the check.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (7)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.propssrc/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Infrastructure/Services/AppStorageHealthCheck.cssrc/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csprojsrc/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cssrc/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Infrastructure/Services/AppPlatform.cssrc/Templates/Boilerplate/Bit.Boilerplate/src/Shared/appsettings.jsonsrc/Templates/Boilerplate/Bit.Boilerplate/src/Tests/Infrastructure/TestsAssemblyInitializer.cs
💤 Files with no reviewable changes (1)
- src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Infrastructure/Services/AppPlatform.cs
closes #12130
Summary by CodeRabbit
Chores
Improvements
Documentation