Skip to content

Improve bit boilerplate external dependencies codes (#12130)#12131

Merged
yasmoradi merged 1 commit intobitfoundation:developfrom
yasmoradi:12130
Feb 26, 2026
Merged

Improve bit boilerplate external dependencies codes (#12130)#12131
yasmoradi merged 1 commit intobitfoundation:developfrom
yasmoradi:12130

Conversation

@yasmoradi
Copy link
Copy Markdown
Member

@yasmoradi yasmoradi commented Feb 26, 2026

closes #12130

Summary by CodeRabbit

  • Chores

    • Updated Aspire framework and related packages to version 13.1.2
    • Updated Microsoft.Agents.AI to version 1.0.0-rc2
  • Improvements

    • Enhanced storage health check validation
    • Simplified database admin interface configurations to use default settings
    • Added Redis connection logging for improved diagnostics
  • Documentation

    • Updated test infrastructure documentation references

@yasmoradi yasmoradi requested a review from Copilot February 26, 2026 13:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 26, 2026

Walkthrough

The PR updates Aspire-related package versions to 13.1.2 and Microsoft.Agents.AI to 1.0.0-rc2, modifies database admin UIs to use default configurations, refines storage health check logic, adds Redis connection logging, and updates test documentation.

Changes

Cohort / File(s) Summary
Dependency Updates
src/Directory.Packages.props, src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj
Bumped Aspire packages (Hosting.Maui, Hosting.Testing, Hosting.DevTunnels, Hosting.AppHost, Hosting.SqlServer, Hosting.PostgreSQL, Hosting.MySql, Hosting.Azure.Storage, Hosting.Keycloak, Hosting.Redis, StackExchange.Redis) from 13.1.1 to 13.1.2 and Microsoft.Agents.AI from 1.0.0-rc1 to 1.0.0-rc2.
Configuration Updates
src/Server/Boilerplate.Server.AppHost/Program.cs, src/Shared/appsettings.json
Removed volume configurations from pgAdmin, PhpMyAdmin, and SqliteWeb to use default settings; added StackExchange.Redis.ConnectionMultiplexer logging level across multiple logging configuration blocks.
Application Logic
src/Server/Boilerplate.Server.Api/Infrastructure/Services/AppStorageHealthCheck.cs
Changed storage accessibility validation from ExistsAsync to ListAsync with max 1 result for directory listing instead of existence check.
Documentation & Code Cleanup
src/Shared/Infrastructure/Services/AppPlatform.cs, src/Tests/Infrastructure/TestsAssemblyInitializer.cs
Removed XML documentation summary from IsLinux property; added using directive for Boilerplate.Tests.Features.Identity and updated test documentation references from IdentityTests to UITests and IntegrationTests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 Whiskers twitch with glee so bright,
Aspire versions dance in the light,
Storage checks now list with care,
Config defaults float through the air,
Redis logs and updates so neat,
The boilerplate's upgrade is sweet! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly refers to improving external dependencies in the bit boilerplate, which directly aligns with the main objective of this changeset that updates multiple dependency versions.
Linked Issues check ✅ Passed The PR addresses the linked issue #12130 by making improvements to external dependencies through version updates and configuration adjustments across multiple files.
Out of Scope Changes check ✅ Passed All changes are within scope: dependency version updates, health check implementation refinement, database admin tool configuration simplification, and documentation updates related to external dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves external dependencies in the bit Boilerplate template by updating Aspire packages to version 13.1.2, fixing documentation references, reducing logging noise from Redis, and improving the storage health check implementation.

Changes:

  • Updated all official Aspire packages from 13.1.1 to 13.1.2 for better compatibility and bug fixes
  • Fixed documentation comments to reference correct test class names (UITests and IntegrationTests instead of IdentityTests)
  • Added Redis connection logging configuration to reduce noise in logs
  • Improved storage health check to use ListAsync instead of ExistsAsync for better reliability across storage providers

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
TestsAssemblyInitializer.cs Added using statement for test classes referenced in XML documentation comments and corrected class names in comments
appsettings.json Added logging configuration for StackExchange.Redis.ConnectionMultiplexer across all environments to reduce log noise
AppPlatform.cs Removed misleading comment stating Linux is not supported (it is supported for Android development)
Program.cs Simplified database admin tool volume configurations by removing custom paths
Boilerplate.Server.AppHost.csproj Updated Aspire.AppHost.Sdk from 13.1.1 to 13.1.2
AppStorageHealthCheck.cs Changed health check from ExistsAsync to ListAsync for more reliable folder existence verification
Directory.Packages.props Updated all official Aspire packages to 13.1.2 and Microsoft.Agents.AI to 1.0.0-rc2

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Infrastructure/Services/AppStorageHealthCheck.cs`:
- Around line 18-22: The health check in AppStorageHealthCheck currently calls
blobStorage.ListAsync(settings.UserProfileImagesDir) which can throw when the
profile-images directory doesn't exist and incorrectly mark storage unhealthy;
fix by first checking existence (use a dedicated exists method on the storage
interface if available) or handle the specific "not found" /
DirectoryNotFoundException/FileNotFoundException from blobStorage.ListAsync and
treat that case as healthy (only treat other exceptions as unhealthy), so update
the health-check logic around blobStorage.ListAsync and
settings.UserProfileImagesDir to detect/mask a missing folder rather than
failing the check.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between b709ef1 and 2a51268.

📒 Files selected for processing (7)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Infrastructure/Services/AppStorageHealthCheck.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Boilerplate.Server.AppHost.csproj
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.AppHost/Program.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Infrastructure/Services/AppPlatform.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/appsettings.json
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Tests/Infrastructure/TestsAssemblyInitializer.cs
💤 Files with no reviewable changes (1)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Infrastructure/Services/AppPlatform.cs

@yasmoradi yasmoradi merged commit 09e8fda into bitfoundation:develop Feb 26, 2026
7 checks passed
@yasmoradi yasmoradi deleted the 12130 branch February 26, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bit Boilerplate external dependencies need some improvements

2 participants