Add new Icon parameter to BitBadge component (#12134)#12135
Add new Icon parameter to BitBadge component (#12134)#12135msynk merged 1 commit intobitfoundation:developfrom
Conversation
WalkthroughThis change adds external icon support to the BitBadge component by introducing a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Notifications/Badge/BitBadge.scss`:
- Line 1: The SCSS import in BitBadge.scss currently includes the .scss
extension which triggers stylelint's scss/load-partial-extension rule; update
the import statement in BitBadge.scss (the `@import`
"../../../Styles/functions.scss"; line) to remove the .scss extension so it
imports the partial as `@import` "../../../Styles/functions"; ensuring consistency
with SCSS partial conventions and newer Sass behavior.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (5)
src/BlazorUI/Bit.BlazorUI/Components/Notifications/Badge/BitBadge.razorsrc/BlazorUI/Bit.BlazorUI/Components/Notifications/Badge/BitBadge.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Notifications/Badge/BitBadge.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Notifications/Badge/BitBadgeDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Notifications/Badge/BitBadgeDemo.razor.cs
closes #12134
Summary by CodeRabbit
New Features
Style
Documentation