Skip to content

Remove redundant z-index from FulllWidth style of BitButton (#12167)#12171

Merged
msynk merged 1 commit intobitfoundation:developfrom
msynk:12167-blazorui-button-fullwidth-zindex-issue
Mar 15, 2026
Merged

Remove redundant z-index from FulllWidth style of BitButton (#12167)#12171
msynk merged 1 commit intobitfoundation:developfrom
msynk:12167-blazorui-button-fullwidth-zindex-issue

Conversation

@msynk
Copy link
Copy Markdown
Member

@msynk msynk commented Mar 15, 2026

closes #12167

Summary by CodeRabbit

  • Style
    • Refined button styling by removing unnecessary stacking context configuration from full-width button layouts.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cc687903-1347-4fbe-b68e-56e36739a053

📥 Commits

Reviewing files that changed from the base of the PR and between 9d641bf and e5a2705.

📒 Files selected for processing (1)
  • src/BlazorUI/Bit.BlazorUI/Components/Buttons/Button/BitButton.scss
💤 Files with no reviewable changes (1)
  • src/BlazorUI/Bit.BlazorUI/Components/Buttons/Button/BitButton.scss

Walkthrough

A single z-index property was removed from the full-width button flow styling rule in the BitButton SCSS component. This modification addresses z-index stacking context issues without altering other button-related rules or functionality.

Changes

Cohort / File(s) Summary
Button Styling Z-Index Fix
src/BlazorUI/Bit.BlazorUI/Components/Buttons/Button/BitButton.scss
Removed z-index: $zindex-base; declaration from .bit-btn-flw rule, leaving width: 100%; as the sole property.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Hoppy changes from this rabbit's eye,
One z-index less—no stacking to deny,
Full-width buttons, clean and bright,
No layer chaos, just pure delight! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically describes the main change: removing a redundant z-index declaration from BitButton's FullWidth style.
Linked Issues check ✅ Passed The PR removes the redundant z-index from BitButton's FullWidth style, directly addressing the z-index bugs reported in issue #12167.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to removing one line (z-index declaration) from BitButton.scss, directly related to resolving the linked issue about z-index problems.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an explicit z-index from the BitButton “FullWidth” style to avoid unintended stacking/overlap behavior (per #12167) while keeping z-index only on button variants that are actually positioned (e.g., floating buttons).

Changes:

  • Removed z-index: $zindex-base; from .bit-btn-flw (full-width button) styling.

@msynk msynk merged commit fdcae81 into bitfoundation:develop Mar 15, 2026
7 checks passed
@msynk msynk deleted the 12167-blazorui-button-fullwidth-zindex-issue branch March 15, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Z-index bugs

3 participants