Utilize ReadOnly parameter in BitDropdown (#12257)#12258
Utilize ReadOnly parameter in BitDropdown (#12257)#12258msynk merged 1 commit intobitfoundation:developfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #12257 by wiring the inherited ReadOnly behavior into BitDropdown so user interactions no longer modify selection/value when the component is read-only.
Changes:
- Added
ReadOnlyguards to selection-changing handlers (item click, clear, dynamic add, combo input, backspace removal). - Added
ReadOnlyguards to internal selection mutation methods to prevent value changes from user-driven flows.
closes #12257
Summary by CodeRabbit