Skip to content

Fix incorrect code in example 12 of BitButton demo page (#12287)#12288

Merged
msynk merged 1 commit into
bitfoundation:developfrom
zahra-yousefi:12287-button-demo-templates-incorrect-paramter
Apr 27, 2026
Merged

Fix incorrect code in example 12 of BitButton demo page (#12287)#12288
msynk merged 1 commit into
bitfoundation:developfrom
zahra-yousefi:12287-button-demo-templates-incorrect-paramter

Conversation

@zahra-yousefi
Copy link
Copy Markdown
Member

@zahra-yousefi zahra-yousefi commented Apr 27, 2026

closes #12287

Summary by CodeRabbit

  • Documentation
    • Updated sample code for the BitRippleLoading component to use the correct size configuration method.

@msynk msynk requested a review from Copilot April 27, 2026 17:16
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 127e1ceb-e37c-4b0e-8781-a60167bfe16f

📥 Commits

Reviewing files that changed from the base of the PR and between 65d07a0 and b89164e.

📒 Files selected for processing (1)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/Button/BitButtonDemo.razor.samples.cs

Walkthrough

A parameter name correction in the BitButton demo code updates the BitRippleLoading component from using Size to CustomSize attribute to align with the correct API.

Changes

Cohort / File(s) Summary
Demo Sample Code
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Buttons/Button/BitButtonDemo.razor.samples.cs
Corrects parameter name in example 12 from Size to CustomSize for the BitRippleLoading component.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny hop, a name so bright,
CustomSize now shines just right,
The sample code sings with delight,
Where parameters dance in demo light! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing incorrect code in example 12 of the BitButton demo page, with reference to the linked issue.
Linked Issues check ✅ Passed The code changes directly address the requirement in issue #12287 by correcting the Size parameter to CustomSize in example 12's BitRippleLoading component.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing the incorrect parameter name in example 12 of BitButton demo, with no out-of-scope modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the sample code in Example 12 of the BitButton demo page by correcting the BitRippleLoading parameter name from Size to CustomSize (per #12287).

Changes:

  • Updated Example 12 sample markup to use CustomSize="20" on BitRippleLoading instead of Size="20".

@msynk msynk merged commit 25329de into bitfoundation:develop Apr 27, 2026
7 checks passed
@zahra-yousefi zahra-yousefi deleted the 12287-button-demo-templates-incorrect-paramter branch April 27, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect parameter name in the sample code of the example 12 of the BitButton demo page

3 participants