Fix duplicate messages in ClientAppMessages class of Boilerplate (#12313)

[zahra-yousefi]

closes #12313

Summary by CodeRabbit

• Refactor
  • Reorganized conditional compilation directives and adjusted constant declarations in application infrastructure code to improve code structure and maintainability.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7187dc77-6af5-4965-ba78-2229dc321942

📥 Commits

Reviewing files that changed from the base of the PR and between bca598a and a5c254b.

📒 Files selected for processing (1)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Infrastructure/Services/ClientAppMessages.cs

---

Walkthrough

ClientAppMessages.cs template file reorganizes conditional-comment directives, repositions constants, and moves the NAVIGATE_TO constant from unconditional to signalR != true conditional compilation region. This addresses duplicate constant definitions detected against the base class.

Changes

ClientAppMessages Template Constants and Conditionals

Layer / File(s)	Summary
Template Directive Reformatting src/Templates/.../ClientAppMessages.cs	Conditional-comment markers near the class header are restructured (comment spacing and directive formatting adjusted) without altering the type declaration.
Constants Reorganization src/Templates/.../ClientAppMessages.cs	SHOW_DIAGNOSTIC_MODAL is repositioned in the constants list; SEARCH_PRODUCTS and AD_HAVE_TROUBLE remain in module/ads conditional wrappers with updated directive formatting.
NAVIGATE_TO Conditional Gating src/Templates/.../ClientAppMessages.cs	A signalR != true conditional-comment region is introduced, and NAVIGATE_TO constant is moved from unconditional scope into this block, making its inclusion in generated code conditional on the signalR template parameter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through constants bright,
Moving NAVIGATE_TO out of sight—
When signalR says "no," it yields the way,
Template directives dance and sway! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR moves NAVIGATE_TO to a conditional section instead of removing it, which does not align with the stated objective to remove duplicated constants entirely.	Remove NAVIGATE_TO, PROFILE_UPDATED, and BACKGROUND_JOB_PROGRESS from ClientAppMessages entirely to resolve the duplicate constant issue and eliminate compiler warnings.
Out of Scope Changes check	⚠️ Warning	The PR includes formatting changes to template directives and relocation of SHOW_DIAGNOSTIC_MODAL that are unrelated to the primary objective of removing duplicate constants.	Focus the PR on removing only the three duplicate constants (NAVIGATE_TO, PROFILE_UPDATED, BACKGROUND_JOB_PROGRESS) and minimize unrelated formatting or structural changes.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main objective of fixing duplicate messages in the ClientAppMessages class.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[yasmoradi]

Please run full-ci and send its link here @zahra-yousefi @msynk