Skip to content

Add Microsoft.EntityFrameworkCore.Design to prevent fallback to 8.x version (#12333)#12335

Merged
yasmoradi merged 2 commits into
developfrom
12333
May 16, 2026
Merged

Add Microsoft.EntityFrameworkCore.Design to prevent fallback to 8.x version (#12333)#12335
yasmoradi merged 2 commits into
developfrom
12333

Conversation

@yasmoradi
Copy link
Copy Markdown
Member

@yasmoradi yasmoradi commented May 16, 2026

closes #12333

Summary

Without an explicit reference to Microsoft.EntityFrameworkCore.Design, the EF Core CLI (dotnet ef) can fall back to resolving an older 8.x.x version of the Design package, which causes compatibility issues in an EF Core 10-powered project.

This PR explicitly pins Microsoft.EntityFrameworkCore.Design (with PrivateAssets="all") in:

  • Directory.Packages.props — central version pin at 10.0.7
  • Boilerplate.Server.Api.csproj — unconditional reference (always needs EF migrations)
  • Boilerplate.Server.Web.csproj — conditional reference (same condition as Microsoft.EntityFrameworkCore.Tools)

Summary by CodeRabbit

  • Chores
    • Added EntityFramework Core Design package to project dependencies across boilerplate template configurations
    • Standardized project file encoding in boilerplate templates

Review Change Stack

yasmoradi and others added 2 commits May 16, 2026 12:38
…ersion (#12333)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…12333)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 02b8c7ed-f5af-445b-b615-ba241eee45e2

📥 Commits

Reviewing files that changed from the base of the PR and between 8ed4bdb and 6715912.

📒 Files selected for processing (3)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Boilerplate.Server.Api.csproj
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Boilerplate.Server.Web.csproj

Walkthrough

This PR adds explicit Microsoft.EntityFrameworkCore.Design package (v10.0.7) references to the Boilerplate templates across centralized package management and two server projects to prevent NuGet version fallback issues when running EF Core 10 CLI commands. UTF-8 BOM markers are also removed from project file headers.

Changes

EntityFrameworkCore.Design Package Addition

Layer / File(s) Summary
Central package version definition
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
Microsoft.EntityFrameworkCore.Design version 10.0.7 is added to the centralized package version catalog alongside other EF Core dependencies.
Project-level package references and BOM cleanup
src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Boilerplate.Server.Api.csproj, src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Web/Boilerplate.Server.Web.csproj
Both server projects add PackageReference entries for Microsoft.EntityFrameworkCore.Design with PrivateAssets="all". The Web project's reference is conditional on the offlineDb build property. UTF-8 BOM markers are removed from both project file headers.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit's hop, so light and free,
Adds Design packages, version-decree!
No fallback frets on EF Core's spree,
BOMs are gone—clean configs, you see! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the primary change: adding Microsoft.EntityFrameworkCore.Design to prevent fallback to 8.x version.
Linked Issues check ✅ Passed All coding requirements from issue #12333 are met: central version pinning in Directory.Packages.props (10.0.7), unconditional reference in Boilerplate.Server.Api.csproj, and conditional reference in Boilerplate.Server.Web.csproj with correct PrivateAssets attribute.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #12333; only Microsoft.EntityFrameworkCore.Design package references and version pinning were added across three files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 12333

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yasmoradi yasmoradi merged commit 2893a3f into develop May 16, 2026
7 checks passed
@yasmoradi yasmoradi deleted the 12333 branch May 16, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Microsoft.EntityFrameworkCore.Design package to Boilerplate to prevent fallback to 8.x version on EF Core 10 projects

1 participant