Improve Boilerplate social sign-in in blazor hybrid (#9557)

[yasmoradi]

closes #9557

Summary by CodeRabbit

• New Features

  • None

• Bug Fixes

  • Simplified URL navigation across platforms
  • Standardized local HTTP server service registration

• Improvements

  • Added automatic window closing for social sign-in page
  • Removed platform-specific conditional logic in service configuration

• Chores

  • Code cleanup and simplification of service registration and navigation methods

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces modifications to the Boilerplate project template, focusing on service configuration and external navigation in a Maui application. The changes include unconditional registration of the ILocalHttpServer service, simplification of URL navigation logic, and the addition of an automatic window closure mechanism for social sign-in pages. These updates aim to streamline the application's service configuration and improve the user experience during authentication processes.

Changes

File	Change Summary
src/.../MauiProgram.Services.cs	Unconditional registration of ILocalHttpServer service, removing platform-specific conditional logic
src/.../MauiExternalNavigationService.cs	Simplified URL navigation using BrowserLaunchMode.SystemPreferred for all platforms
src/.../SocialSignedInPage.razor	Added JavaScript to automatically close the window after social sign-in

Assessment against linked issues

Objective	Addressed	Explanation
Improve social sign-in for Blazor hybrid [#9557]	✅

Poem

🐰 A rabbit's tale of code so bright,
Services aligned with all their might,
Windows close, browsers sing,
Simplicity now takes wing!
Boilerplate dances with delight 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Components/SocialSignedInPage.razor (1)

49-51: Potential window.close() fallback.

Some browsers may block closing a window unless it was opened by a script. Consider adding a fallback message or redirect if the window remains open to handle restrictive browser settings.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a0b43d and 17ebc6f.

📒 Files selected for processing (3)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/MauiProgram.Services.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Services/MauiExternalNavigationService.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Components/SocialSignedInPage.razor (1 hunks)

🔇 Additional comments (2)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/Services/MauiExternalNavigationService.cs (1)

7-7: Simplification of URL navigation logic seems solid.

The universal use of BrowserLaunchMode.SystemPreferred removes platform-specific checks and helps maintain a single entry point for external navigation. This reduces conditional complexity and fosters code consistency.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Maui/MauiProgram.Services.cs (1)

42-42: Unconditionally registering the local HTTP server.

Always registering ILocalHttpServer simplifies the service setup and ensures consistent availability across all platforms. Confirm that no performance or resource usage challenges arise when this service is not strictly needed.