Add NoValidate parameter to BitInputBase (#9616)

[msynk]

closes #9616

Summary by CodeRabbit

• New Features
  • Added an option to disable input validation for form inputs
• Improvements
  • Enhanced flexibility of input components by allowing developers to control validation behavior

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces a new NoValidate boolean parameter to the BitInputBase<TValue> class in the Blazor UI input components. This parameter provides developers with the ability to disable input validation for specific scenarios. When set to true, the parameter bypasses validation checks in various methods of the input component, offering more flexibility in handling input validation.

Changes

File	Change Summary
src/BlazorUI/.../BitInputBase.cs	Added NoValidate boolean parameter to control input validation

Assessment against linked issues

Objective	Addressed	Explanation
Add NoValidate flag to input components [#9616]	✅

Poem

🐰 A rabbit's tale of input might,
Where validation takes a gentle flight
NoValidate waves its magic wand
Skipping checks with a playful bond
Flexibility dancing, code so bright! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/BlazorUI/Bit.BlazorUI/Components/Inputs/BitInputBase.cs (1)

66-70: Introduce a cautionary note in the documentation.
While adding the NoValidate parameter is a great way to offer flexibility in disabling validation, it’s worth including a brief remark about potential risks—especially in cases where skipping validation might introduce unexpected behaviors or security concerns. Consider refining the XML summary to guide consumers on when and why they may wish to use it.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efbf29f and 9897dd1.

📒 Files selected for processing (1)

• src/BlazorUI/Bit.BlazorUI/Components/Inputs/BitInputBase.cs (7 hunks)

🔇 Additional comments (5)

src/BlazorUI/Bit.BlazorUI/Components/Inputs/BitInputBase.cs (5)

149-153: Parameter handling looks consistent.
The implementation matches the approach used for other parameters (removing from parametersDictionary to avoid reprocessing). No concerns here.

---

211-233: Conditionally skipping EditContext initialization confirms best practice.
The if-statement ensures that initialization logic and the EditContext checks are only executed when NoValidate is set to false. This prevents unnecessary event handling overhead and aligns with the NoValidate parameter's intended functionality. Looks solid.

---

Line range hint 350-367: Logical flow for parsing errors is consistent with the new NoValidate parameter.
When NoValidate is false, displaying validation messages is appropriate. Otherwise, the code gracefully bypasses the _parsingFailed logic. No critical issues noted.

---

385-388: Good practice to notify field changes only when validation is enabled.
This approach prevents spurious notifications to the EditContext. It ensures that the state is updated only if validations are required.

---

411-411: Short-circuit return fosters performance and clarity.
Early return if EditContext is null or NoValidate is true helps avoid needless attribute updates and clarifies the operational flow.