Add RTL sample for BitMessageBox demo page (#9673)#9679
Add RTL sample for BitMessageBox demo page (#9673)#9679msynk merged 1 commit intobitfoundation:developfrom
Conversation
WalkthroughThe pull request adds a new Right-To-Left (RTL) example to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Extras/MessageBox/BitMessageBoxDemo.razor.samples.cs (1)
80-83: LGTM! Consider adding a comment for non-Persian speakers.The RTL example is well-structured and demonstrates proper usage of BitMessageBox's RTL support with Persian text. Consider adding a comment to translate the Persian text for non-Persian speakers:
private readonly string example6RazorCode = @" <BitCard Style=""padding:0""> + @* Title: Message Title, Body: Test message text..., OkText: Confirm *@ <BitMessageBox Dir=""BitDir.Rtl"" Title=""عنوان پیام"" Body=""متن تست پیام..."" OkText=""تایید"" /> </BitCard>";src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Extras/MessageBox/BitMessageBoxDemo.razor (1)
61-71: LGTM! Consider adding lang attribute for better accessibility.The RTL example is well-implemented and follows the established pattern. For better accessibility and screen reader support, consider adding the
langattribute to specify the language:- <div dir="rtl"> + <div dir="rtl" lang="fa">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Extras/MessageBox/BitMessageBoxDemo.razor(2 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Extras/MessageBox/BitMessageBoxDemo.razor.samples.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build and test
This closes #9673
Summary by CodeRabbit
New Features
BitMessageBoxcomponent in right-to-left (RTL) layoutDocumentation