Handle boilerplate sales module home page infinite scroll errors (#9796)

[yasmoradi]

closes #9796

Summary by CodeRabbit

• Bug Fixes

  • Enhanced error handling on the home page to ensure a seamless experience even when data retrieval issues occur.

• Refactor

  • Improved background data loading for product and category displays, contributing to a smoother and more responsive interface.

[coderabbitai]

Walkthrough

This pull request updates the cancellation token usage and error handling logic in several client pages. In both the Categories and Products pages, the cancellation token is now sourced from the incoming request rather than a global token. The HomePage has been enhanced with a try-catch block in its product-loading method to handle exceptions gracefully without propagating errors, returning an empty list instead.

Changes

File(s)	Change Summary
src/Templates/.../Authorized/Categories/CategoriesPage.razor.cs src/Templates/.../Authorized/Products/ProductsPage.razor.cs	Updated API calls to use req.CancellationToken instead of CurrentCancellationToken
src/Templates/.../Authorized/HomePage.razor.cs	Added error handling (try-catch) in LoadProducts and updated the cancellation token to use request.CancellationToken

Sequence Diagram(s)

sequenceDiagram
    participant HomePage
    participant ProductViewController as PVC
    participant ExceptionHandler as EH
    HomePage->>PVC: Fetch products using request.CancellationToken
    alt Successful Response
        PVC-->>HomePage: Returns product list
    else Exception Occurs
        PVC-->>HomePage: Throws exception
        HomePage->>EH: Handle(exception)
        HomePage-->>Caller: Return empty array
    end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Handle errors during infinite scroll on sales module home page (#9796)	✅

Poem

Hop, hop, little bunny sings with glee,
Cancellation tokens now dance merrily.
Errors are caught in a try-catch embrace,
Code flows smooth at an optimized pace.
With twitching whiskers, I celebrate this race! 🐰✨

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20b96a3 and 1670ca5.

📒 Files selected for processing (3)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Categories/CategoriesPage.razor.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Products/ProductsPage.razor.cs (1 hunks)
• src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/HomePage.razor.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (4)

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Categories/CategoriesPage.razor.cs (1)

59-59: LGTM! Good improvement in cancellation token usage.

Using req.CancellationToken instead of CurrentCancellationToken is more appropriate as it properly scopes the cancellation to the specific data request lifecycle.

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/HomePage.razor.cs (2)

96-106: LGTM! Excellent error handling implementation.

The try-catch block with ExceptionHandler and empty array fallback ensures graceful degradation of the infinite scroll functionality.

---

105-105: Verify C# version compatibility.

The empty array syntax [] is a C# 12 feature. Ensure your project's target framework supports C# 12.

✅ Verification successful

🌐 Web query:

What is the minimum .NET version required for C# 12 collection expressions?

Length of output: 4369

---

Action: Confirm your project targets .NET 8.
The empty array syntax (return [];) leverages C# 12 collection expressions, which are officially supported only with .NET 8. If your project is targeting an earlier version, you may run into compatibility issues unless you employ unsupported workarounds (e.g., PolySharp).

src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Pages/Authorized/Products/ProductsPage.razor.cs (1)

81-81: LGTM! Consistent improvement in cancellation token usage.

The change to use req.CancellationToken maintains consistency with other pages and properly scopes the cancellation to the specific request lifecycle.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.