Add missing Sales condition to ProductDto in Boilerplate (#9831)

[msynk]

closes #9831

Summary by CodeRabbit

• New Features
  • Enhanced product page links in the Sales module: Product URLs now dynamically incorporate product details, providing a more tailored navigation experience for Sales users.

[coderabbitai]

Walkthrough

This pull request updates the ProductDto class by wrapping the PageUrl property in conditional compilation directives. The change ensures that the PageUrl property is only included in the build when the module is set to "Sales". The underlying URL construction remains unchanged.

Changes

File	Change Summary
src/.../Products/ProductDto.cs	Added preprocessor directives (//#if (module == "Sales") ... //#endif) around the PageUrl property.

Assessment against linked issues

Objective	Addressed	Explanation
Include Sales module condition for PageUrl property (#9831)	✅

Poem

I'm a rabbit with a hop so free,
Coding conditional joy for all to see,
PageUrl now skips when Sales is not near,
A clean compile brings a cheer,
With every line, my code garden grows,
Hopping through changes, where innovation flows.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19d0519 and a858a91.

📒 Files selected for processing (1)

• src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Dtos/Products/ProductDto.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build and test

🔇 Additional comments (1)

src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Dtos/Products/ProductDto.cs (1)

56-58: LGTM! The conditional compilation directive is correctly implemented.

The changes align with the PR objectives by properly wrapping the PageUrl property with the Sales module condition.

Let's verify that Urls.ProductPage is defined:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for Urls.ProductPage definition
rg -A 2 "ProductPage\s*=|ProductPage\s*{" 

Length of output: 169

---

I'll run an improved search command to verify if there's any definition or assignment for Urls.ProductPage in the codebase.

---

🏁 Script executed:

#!/bin/bash
echo "Searching for URLs.ProductPage occurrences..."
rg "Urls\.ProductPage" -n -C 2

echo -e "\nSearching for assignments to ProductPage..."
rg "ProductPage\s*=" -n -C 2

echo -e "\nSearching for ProductPage property definitions..."
rg "ProductPage\s*{" -n -C 2

Length of output: 3302

---

LGTM! The PageUrl property is correctly wrapped in the Sales module condition, and the Urls.ProductPage identifier is properly defined in src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Urls.cs (as "public const string ProductPage = "/product";").

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.