Skip to content

Add IsAotCompatible across projects (#9992)#9995

Merged
msynk merged 35 commits intobitfoundation:developfrom
yasmoradi:9992
Feb 22, 2025
Merged

Add IsAotCompatible across projects (#9992)#9995
msynk merged 35 commits intobitfoundation:developfrom
yasmoradi:9992

Conversation

@yasmoradi
Copy link
Member

@yasmoradi yasmoradi commented Feb 21, 2025

closes #9992

Summary by CodeRabbit

  • New Features
    • Enhanced overall project performance by enabling Ahead-of-Time (AOT) compilation support.
    • Activated AOT optimization for iOS Release builds.
    • Extended AOT compatibility to template projects for consistent performance improvements.

@coderabbitai
Copy link

coderabbitai bot commented Feb 21, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request adds two new properties to enable Ahead-of-Time (AOT) compilation. In two separate property files, <IsAotCompatible>true</IsAotCompatible> is introduced to designate AOT compatibility. Additionally, <PublishAot>true</PublishAot> is added to a MAUI project file under a condition for iOS Release builds. No other modifications are made.

Changes

File(s) Change Summary
src/Bit.Build.props
src/Templates/.../Directory.Build.props
Added <IsAotCompatible>true</IsAotCompatible> property in the <PropertyGroup> to indicate AOT compatibility.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj Added <PublishAot>true</PublishAot> property within a <PropertyGroup> conditioned on the target framework containing -ios and the configuration being Release.

Sequence Diagram(s)

sequenceDiagram
    participant B as Build Process
    participant P as Properties File
    participant A as AOT Compiler

    B->>P: Load configuration properties
    alt General AOT Compatibility
        P-->>B: Return IsAotCompatible = true
    end
    alt iOS Release Build
        B->>P: Check conditional properties for iOS Release
        P-->>B: Return PublishAot = true
        B->>A: Initiate AOT compilation
    else Other Builds
        B->>A: Proceed with standard build process
    end
Loading

Poem

I'm a rabbit with a hop so bright,
New flags in our code made my heart light!
"IsAotCompatible" and "PublishAot" on display,
Guiding our builds in a brand-new way.
With joyful hops and bytes that gleam,
I celebrate these changes in my AOT dream! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/Bit.Build.props (1)

35-35: Fix indentation to maintain consistency.

The indentation uses spaces while the rest of the file uses tabs. Maintain consistent indentation throughout the file.

-        <IsAotCompatible>true</IsAotCompatible>
+		<IsAotCompatible>true</IsAotCompatible>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8d4bec and f850d70.

📒 Files selected for processing (3)
  • src/Bit.Build.props (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build and test
🔇 Additional comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)

7-7: LGTM! Well-placed property.

The IsAotCompatible property is correctly placed and properly indented, grouped with other compiler-related properties.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1)

39-43: LGTM! Well-integrated AOT configuration.

The PublishAot property is correctly configured for iOS Release builds, complementing existing performance optimizations like EnableSGenConc and MtouchInterpreter.

@msynk msynk marked this pull request as ready for review February 22, 2025 08:10
@msynk msynk changed the title Add IsAotCompatible across projects Add IsAotCompatible across projects (#9992) Feb 22, 2025
@msynk msynk merged commit 2b0c828 into bitfoundation:develop Feb 22, 2025
3 checks passed
@yasmoradi yasmoradi deleted the 9992 branch February 22, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Missing <IsAotCompatible>true</IsAotCompatible> across projects

2 participants