Add IsAotCompatible across projects (#9992)#9995
Add IsAotCompatible across projects (#9992)#9995msynk merged 35 commits intobitfoundation:developfrom yasmoradi:9992
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request adds two new properties to enable Ahead-of-Time (AOT) compilation. In two separate property files, Changes
Sequence Diagram(s)sequenceDiagram
participant B as Build Process
participant P as Properties File
participant A as AOT Compiler
B->>P: Load configuration properties
alt General AOT Compatibility
P-->>B: Return IsAotCompatible = true
end
alt iOS Release Build
B->>P: Check conditional properties for iOS Release
P-->>B: Return PublishAot = true
B->>A: Initiate AOT compilation
else Other Builds
B->>A: Proceed with standard build process
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Bit.Build.props (1)
35-35: Fix indentation to maintain consistency.The indentation uses spaces while the rest of the file uses tabs. Maintain consistent indentation throughout the file.
- <IsAotCompatible>true</IsAotCompatible> + <IsAotCompatible>true</IsAotCompatible>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/Bit.Build.props(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build and test
🔇 Additional comments (2)
src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1)
7-7: LGTM! Well-placed property.The
IsAotCompatibleproperty is correctly placed and properly indented, grouped with other compiler-related properties.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1)
39-43: LGTM! Well-integrated AOT configuration.The
PublishAotproperty is correctly configured for iOS Release builds, complementing existing performance optimizations likeEnableSGenConcandMtouchInterpreter.
closes #9992
Summary by CodeRabbit