[bitnami/keydb] ci: simplify goss tests#29088
Merged
juan131 merged 2 commits intobitnami:mainfrom Aug 28, 2024
Merged
Conversation
Signed-off-by: juan131 <jariza@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Goss tests are executed inside the
keydb-master-0pod and, we're implicitly testing thatkeydb-masterservice works as expected (otherwise Replica pods won't be able to sync data from the master).Therefore, we can simplify Goss tests and use
127.0.0.1to runkeydb-clicommands that target the master.Benefits
Simplify CI tests
Possible drawbacks
None
Applicable issues
None
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.