Skip to content

Conversation

@gdlx
Copy link
Contributor

@gdlx gdlx commented Oct 9, 2024

Description of the change

Adds a dataDir compactor to customize the data directory.

Benefits

Allows the setting of a different data directory without overriding the whole args list.

Possible drawbacks

None

Applicable issues

Fixes #29835

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos triage Triage is needed labels Oct 9, 2024
@github-actions github-actions bot requested a review from carrodher October 9, 2024 19:42
@gdlx gdlx force-pushed the thanos-configurable-data-dir branch 3 times, most recently from d673308 to 6d9ca9c Compare October 9, 2024 19:52
@carrodher
Copy link
Member

Thanks for your contribution! Could you please bump the chart version in the Chart.yaml? This is necessary to test the changes and cut a new release.

In the same way, this is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@gdlx gdlx force-pushed the thanos-configurable-data-dir branch 2 times, most recently from ee5d72d to 1d61d44 Compare October 11, 2024 07:53
@gdlx
Copy link
Contributor Author

gdlx commented Oct 11, 2024

Hi @carrodher,
I just bumped the chart and fixed the markdown issue.
About the commit signature, it wasn't signed when opening the PR, but I think I fixed it before you asked. Did I do something wrong ?

@carrodher
Copy link
Member

The DCO check is still failing, see https://github.com/bitnami/charts/pull/29856/checks?check_run_id=31396595990 for some tips about how to fix it

Signed-off-by: Gauthier Delacroix <gauthier.delacroix@gmail.com>
@gdlx gdlx force-pushed the thanos-configurable-data-dir branch from 64918ae to eaac998 Compare October 11, 2024 10:12
Bitnami Containers added 2 commits October 11, 2024 10:17
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@gdlx
Copy link
Contributor Author

gdlx commented Oct 11, 2024

@carrodher It seems to be all ok now.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 13, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 13, 2024
@github-actions github-actions bot removed the request for review from carrodher October 13, 2024 16:49
@github-actions github-actions bot requested a review from dgomezleon October 13, 2024 16:49
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Please, bump a minor version since it adds a new param.

gdlx and others added 3 commits October 14, 2024 13:55
Co-authored-by: David Gomez <davidbhlm@gmail.com>
Signed-off-by: Gauthier Delacroix <1533042+gdlx@users.noreply.github.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
dgomezleon
dgomezleon previously approved these changes Oct 15, 2024
@dgomezleon dgomezleon enabled auto-merge (squash) October 15, 2024 07:03
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@gdlx
Copy link
Contributor Author

gdlx commented Oct 24, 2024

@dgomezleon Is there something else needed for this review ?
It says 1 approving review is required to merge it but I'm not sure if it's all good.

@dgomezleon dgomezleon merged commit e8c23ba into bitnami:main Oct 24, 2024
@gdlx
Copy link
Contributor Author

gdlx commented Oct 24, 2024

Thanks !

@gdlx gdlx deleted the thanos-configurable-data-dir branch October 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solved thanos verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bitnami/thanos] data-dir should be configurable

3 participants