-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[bitnami/thanos] Add compactor dataDir setting #29856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d673308 to
6d9ca9c
Compare
|
Thanks for your contribution! Could you please bump the chart version in the Chart.yaml? This is necessary to test the changes and cut a new release. In the same way, this is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
ee5d72d to
1d61d44
Compare
|
Hi @carrodher, |
|
The DCO check is still failing, see https://github.com/bitnami/charts/pull/29856/checks?check_run_id=31396595990 for some tips about how to fix it |
Signed-off-by: Gauthier Delacroix <gauthier.delacroix@gmail.com>
64918ae to
eaac998
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
|
@carrodher It seems to be all ok now. |
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
dgomezleon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Please, bump a minor version since it adds a new param.
Co-authored-by: David Gomez <davidbhlm@gmail.com> Signed-off-by: Gauthier Delacroix <1533042+gdlx@users.noreply.github.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
|
@dgomezleon Is there something else needed for this review ? |
|
Thanks ! |
Description of the change
Adds a
dataDircompactor to customize the data directory.Benefits
Allows the setting of a different data directory without overriding the whole args list.
Possible drawbacks
None
Applicable issues
Fixes #29835
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm