Skip to content

Conversation

@migruiz4
Copy link
Member

@migruiz4 migruiz4 commented Apr 8, 2025

Description of the change

We accidentally removed the 'Parameters' section of the bitnami/common Readme in this PR: #14874

I think we removed it to avoid errors after adding the markdown-lint action, then we forgot to restore it.

In this PR I restored the existing values and updated it with the current ones.

Benefits

Avoid broken links in other READMEs that referenced this section.

Possible drawbacks

None known

Applicable issues

Additional information

Unlike other tables, this one isn't automated, so it needs to be manually updated when adding new helpers.
For ease of maintenance I recommend using a document formatter, e.g. markdown-lint for VSCode.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
@github-actions github-actions bot added common verify Execute verification workflow for these changes bitnami labels Apr 8, 2025
@github-actions github-actions bot requested a review from jotamartos April 8, 2025 07:35
@migruiz4 migruiz4 merged commit 72f3f35 into main Apr 9, 2025
12 of 13 checks passed
@migruiz4 migruiz4 deleted the restore-common-readme branch April 9, 2025 07:45
@github-actions github-actions bot added the solved label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bitnami common solved verify Execute verification workflow for these changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants