[bitnami/harbor] Feature/external db url secret#4736
Merged
FraPazGal merged 6 commits intobitnami:masterfrom Dec 16, 2020
Merged
[bitnami/harbor] Feature/external db url secret#4736FraPazGal merged 6 commits intobitnami:masterfrom
FraPazGal merged 6 commits intobitnami:masterfrom
Conversation
TL;DR ===== - Allow Postgres endpoints to be defined via environment secretKeyRef - Disable SSL by default (no longer `nil`) for external database connections Detail ====== This change allows you to define the Postgres endpoint as a secret value, rather than providing passwords in raw values files. A new secret template is created for notary to introduce relevant environment variables for the notary service. Additionally, the default configuration for `externalDatabase.sslmode` was configured as `nil`. This change explicitly sets `disable` for both `values.yaml` and `values-production.yaml`. Chart version received a patch version bump. This _could_ potentially be seen as a minor version bump, depending on your interpretation of semantic versioning. Co-authored-by: Robert Van Voorhees <rvanvoorhees@vmware.com>
Co-authored-by: Francisco de Paz Galán <fdepaz@vmware.com>
Co-authored-by: Francisco de Paz Galán <fdepaz@vmware.com>
Contributor
Author
|
@FraPazGal thank you for the review, added in all suggestions. |
MissakaI
pushed a commit
to MissakaI/bitnami-helm-charts
that referenced
this pull request
Dec 24, 2020
* [bitnami/harbor] Define external psql endpoint via secret, set sslmode TL;DR ===== - Allow Postgres endpoints to be defined via environment secretKeyRef - Disable SSL by default (no longer `nil`) for external database connections Detail ====== This change allows you to define the Postgres endpoint as a secret value, rather than providing passwords in raw values files. A new secret template is created for notary to introduce relevant environment variables for the notary service. Additionally, the default configuration for `externalDatabase.sslmode` was configured as `nil`. This change explicitly sets `disable` for both `values.yaml` and `values-production.yaml`. Chart version received a patch version bump. This _could_ potentially be seen as a minor version bump, depending on your interpretation of semantic versioning. Co-authored-by: Robert Van Voorhees <rvanvoorhees@vmware.com> * Bump chart version. * Update bitnami/harbor/Chart.yaml Co-authored-by: Francisco de Paz Galán <fdepaz@vmware.com> * Update bitnami/harbor/templates/notary/notary-secret-envvars.yaml Co-authored-by: Francisco de Paz Galán <fdepaz@vmware.com> * Need this for all values since it's referencing the data file not stringdata now. Co-authored-by: conzetti <conzetti@gmail.com> Co-authored-by: Francisco de Paz Galán <fdepaz@vmware.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
nil) for external databaseconnections
Detail
This change allows you to define the Postgres endpoint as a secret
value, rather than providing passwords in raw values files. A new secret
template is created for notary to introduce relevant environment
variables for the notary service.
Additionally, the default configuration for
externalDatabase.sslmodewas configured as
nil. This change explicitly setsdisablefor bothvalues.yamlandvalues-production.yaml.Chart version received a patch version bump. This could potentially
be seen as a minor version bump, depending on your interpretation of
semantic versioning.
Co-authored-by: @conzetti
Checklist
Chart.yamlaccording to semver.[bitnami/chart])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files