Transaction and block version are signed integers

[afk11]

https://en.bitcoin.it/wiki/Protocol_documentation#Block_Headers
https://en.bitcoin.it/wiki/Protocol_documentation#tx

The transaction and block version fields are both int32's (little endian encoded), so technically the range is -2^31 to 2^31 (not zero to 2^32)

[gabegattis]

Good catch.

https://github.com/bitcoin/bitcoin/blob/57b34599b2deb179ff1bd97ffeab91ec9f904d85/src/primitives/block.h#L24

[afk11]

Merge please?

[kleetus]

The Bitcoin wiki isn't the Bitcoin protocol's specification. Nonetheless, @afk11 is correct based on Bitcoin Core's source to date. Please see:

https://github.com/bitcoin/bitcoin/blob/master/src/primitives/block.h#L24
https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L319

'int32_t' is type defined to 'int' in coda.h in the Linux kernel header files. I think it is safe to assume that the other supported platforms that Bitcoin actively supports with also yield int32_t to a 4 byte length and handle the signed magnitude encoding correctly given the compiler used.

This is probably a breaking api change, but if you have a counter argument as to why it is not, please reply.

[gabegattis]

I'm going to pull down the code and do a proper review later today. I think we can get probably get this pulled in by tomorrow.

[kleetus]

Removing the api change label. @gabegattis and I don't think this will break the api in any way.

[gabegattis]

👍

[gabegattis]

Thanks @afk11