This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Closed
Conversation
eordano
force-pushed
the
sighash-pre
branch
2 times, most recently
from
bd16d80 to
3eca2c7
Compare
Contributor
|
Thanks. Code ACK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit exposes the calculation of the preimage of transactions to be signed. It is useful for sharing to an external signing system so the software that will sign it knows what it is signing without having to create the "txcopy". This way the external signing can still verify what it is signing, without needing to handle the complexity of crafting the transaction, and just needs to parse it and verify the coins it's spending and where it is spending to.
The commits should make clear that there were no significant changes to this critical part. The test added is for coverage of the SIGHASH_SINGLE bug, which requires special handling.