This repository was archived by the owner on Apr 3, 2019. It is now read-only.
add a noSorting option to the multi sig inputs#138
Closed
gmelika wants to merge 24 commits intobitpay:masterfrom
Closed
add a noSorting option to the multi sig inputs#138gmelika wants to merge 24 commits intobitpay:masterfrom
noSorting option to the multi sig inputs#138gmelika wants to merge 24 commits intobitpay:masterfrom
Conversation
…, can call Input method
Using this code in the test to get test data:
```
string TxHexStr(CTransaction tx)
{
CDataStream ssTx(SER_NETWORK, PROTOCOL_VERSION);
ssTx << tx;
std::string ssTxStr = ssTx.str();
return HexStr(ssTxStr);
}
std::cout << "scriptPubkey1: " + HexStr(scriptPubkey1) + "\n";
std::cout << "output1: " + TxHexStr(output1) + "\n";
```
From commit bitcoin core 0.13.0 commit: a402396dce64c42ea73535b7dde4a9164d430438
In the file: src/test/transaction_tests.cpp#L493
From commit bitcoin core 0.13.0 commit: a402396dce64c42ea73535b7dde4a9164d430438 In the file: src/test/transaction_tests.cpp - pay-to-compressed publickey (v0) - p2sh witness pay-to-compressed pubkey (v0) - witness 2-of-2 multisig - p2sh witness 2-of-2 multisig
Contributor
|
Please send only the feature "For better compatibility with existing systems that do not sort public keys by default. |
matiu
suggested changes
Oct 26, 2017
Contributor
matiu
left a comment
matiu
left a comment
There was a problem hiding this comment.
Resend only the described feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For better compatibility with existing systems that do not sort public keys by default.