Skip to content

Conversation

@maraoz
Copy link
Contributor

@maraoz maraoz commented Feb 24, 2015

No description provided.

@maraoz maraoz changed the title WIP Add NetworkMonitor Add NetworkMonitor Feb 25, 2015
@maraoz maraoz closed this Feb 25, 2015
@maraoz maraoz reopened this Feb 25, 2015
@maraoz maraoz force-pushed the add/networkmanager branch from 37c1168 to c84c66f Compare February 25, 2015 19:57
@coveralls
Copy link

Coverage Status

Coverage decreased (-13.82%) to 86.18% when pulling 37c1168 on maraoz:add/networkmanager into 5d2d17c on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.82%) to 86.18% when pulling 37c1168 on maraoz:add/networkmanager into 5d2d17c on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling df04857 on maraoz:add/networkmanager into 5d2d17c on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-13.82%) to 86.18% when pulling c84c66f on maraoz:add/networkmanager into 5d2d17c on bitpay:master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort this list? A good practice is to separate it in 3 groups:

1 - Third party libraries
2 - Our external libraries (bitcore)
3 - Project specific clases

E.g:

var util = require('util');
var Promise = require('bluebird');
var EventEmitter = require('events').EventEmitter;

var bitcore = require('bitcore');
var Networks = bitcore.Networks;
var $ = bitcore.util.preconditions;
var _ = bitcore.deps._;
var p2p = require('bitcore-p2p');
var Peer = p2p.Peer;
var Messages = p2p.Messages;

var EventBus = require('./eventbus');

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling df81629 on maraoz:add/networkmanager into 5d2d17c on bitpay:master.

@eordano
Copy link
Contributor

eordano commented Feb 26, 2015

LGTM

@yemel merge if no further comments

@yemel
Copy link
Contributor

yemel commented Feb 26, 2015

ACK

yemel added a commit that referenced this pull request Feb 26, 2015
@yemel yemel merged commit 18aefe6 into bitpay:master Feb 26, 2015
kleetus added a commit that referenced this pull request Jul 31, 2015
Make directory if it doesn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants