Added a check for the right number of tip events.#201
Merged
braydonf merged 1 commit intobitpay:masterfrom Sep 8, 2015
kleetus:fix_regtest
Merged
Added a check for the right number of tip events.#201braydonf merged 1 commit intobitpay:masterfrom kleetus:fix_regtest
braydonf merged 1 commit intobitpay:masterfrom
kleetus:fix_regtest
Conversation
Contributor
kleetus
commented
Sep 8, 2015
kleetus
commented
- Since we have a spin lock that leads to the callback from a tip update, there could be cases where the callback assigned to a tip update isn't the one matching the last generate.
- The architectural decision is to leave the spin lock in place to lower the number of possible callbacks for tip updates.
- Since we have a spin lock that leads to the callback from a tip update, there could be cases where the callback assigned to a tip update isn't the one matching the last generate. - The architectural decision is to leave the spin lock in place to lower the number of possible callbacks for tip updates.
Contributor
|
LGTM |
braydonf
pushed a commit
that referenced
this pull request
Sep 8, 2015
Added a check for the right number of tip events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.