Add option to retrieve an address from an output#1009
Closed
eordano wants to merge 1 commit intobitpay:masterfrom
Closed
Add option to retrieve an address from an output#1009eordano wants to merge 1 commit intobitpay:masterfrom
eordano wants to merge 1 commit intobitpay:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
If no address associated to the script the accessor will throw an error.
I think returning null is a good solution for this scenario, that provides a clean way to check if the output has an address without a try/catch block. The other option is to make it a function and let the error bubble up.
Contributor
|
I would do it via a method, not a property. |
Contributor
Author
|
Closing, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.