Skip to content

Conversation

@trevinhofmann
Copy link
Contributor

There is documentation available at
http://bitcore.io/api/#Create_a_Multisig_Address but I think it would
also be useful in the address.md document.

There is documentation available at
http://bitcore.io/api/#Create_a_Multisig_Address but I think it would
also be useful in the address.md document.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.91% when pulling 7fd9e8e on thofmann:master into 970bf12 on bitpay:master.

@braydonf
Copy link
Contributor

braydonf commented Feb 4, 2015

LGTM.

One small detail: instances should be lowerCamelCase, and only constructors with UpperCamel.

@trevinhofmann
Copy link
Contributor Author

Thanks. I agree with lowerCamelCase, but was mostly following the example from here (also found here).

Should this example be changed as well?

Edit: I have added a commit to apply lowerCamelCase in both locations.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 96.91% when pulling 99c88c4 on thofmann:master into 970bf12 on bitpay:master.

braydonf pushed a commit that referenced this pull request Feb 4, 2015
Add documentation for instantiating P2SH multisig
@braydonf braydonf merged commit 8686e5b into bitpay:master Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants