Skip to content

Improvements to Transaction#1028

Merged
maraoz merged 4 commits intobitpay:masterfrom
eordano:transaction/changeupdate
Feb 4, 2015
Merged

Improvements to Transaction#1028
maraoz merged 4 commits intobitpay:masterfrom
eordano:transaction/changeupdate

Conversation

@eordano
Copy link
Contributor

@eordano eordano commented Feb 4, 2015

This commit contains a series of modifications that where detected from @matiu's feedback:

  • The addInput method was not being used when from was called with a non-p2sh output
  • The change output had no actual reason not to be updated on each modification, as there is no private key cache that could be signing more often than what we wanted for performance issues
  • Add a fee field to the toObject serialization

@eordano eordano force-pushed the transaction/changeupdate branch from cd44458 to 1f45e88 Compare February 4, 2015 15:50
@maraoz
Copy link
Contributor

maraoz commented Feb 4, 2015

LGTM

@maraoz
Copy link
Contributor

maraoz commented Feb 4, 2015

please check test coverage: coverage/coveralls — Coverage decreased (-0.02%) to 96.89%1

@eordano eordano force-pushed the transaction/changeupdate branch from 4d23d51 to e568a87 Compare February 4, 2015 18:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.99% when pulling e568a87 on eordano:transaction/changeupdate into c07ee19 on bitpay:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 96.99% when pulling e568a87 on eordano:transaction/changeupdate into c07ee19 on bitpay:master.

maraoz added a commit that referenced this pull request Feb 4, 2015
@maraoz maraoz merged commit cd7e5d5 into bitpay:master Feb 4, 2015
@maraoz maraoz removed the in progress label Feb 4, 2015
@eordano eordano mentioned this pull request Feb 5, 2015
@eordano eordano deleted the transaction/changeupdate branch February 13, 2015 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants