Feature/eth uri #2421
Merged
Feature/eth uri #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkook
force-pushed
the
feature/ethUri
branch
8 times, most recently
from
6109e0e to
d737be0
Compare
micahriggan
reviewed
Sep 30, 2019
MIKE1203
approved these changes
Sep 30, 2019
MIKE1203
previously approved these changes
Sep 30, 2019
justinkook
force-pushed
the
feature/ethUri
branch
2 times, most recently
from
b7b360e to
059f7e0
Compare
matiu
suggested changes
Oct 1, 2019
Contributor
matiu
left a comment
matiu
left a comment
There was a problem hiding this comment.
Please add tests.
It woud be nice to pull the test vectors from other implementation.
justinkook
force-pushed
the
feature/ethUri
branch
2 times, most recently
from
28ff2d4 to
029548b
Compare
matiu
suggested changes
Oct 1, 2019
justinkook
force-pushed
the
feature/ethUri
branch
from
afe644f to
13ab1fc
Compare
micahriggan
previously approved these changes
Oct 1, 2019
justinkook
force-pushed
the
feature/ethUri
branch
3 times, most recently
from
0ccedff to
6403820
Compare
matiu
reviewed
Oct 1, 2019
justinkook
force-pushed
the
feature/ethUri
branch
from
6403820 to
274c684
Compare
justinkook
force-pushed
the
feature/ethUri
branch
from
274c684 to
f03af72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URIs based on EIP - 681 / EIP - 831