Allow web3 provider options for bitcore.config.js#2744
Merged
matiu merged 1 commit intobitpay:masterfrom Mar 13, 2020
Merged
Conversation
micahriggan
approved these changes
Mar 10, 2020
Contributor
micahriggan
left a comment
There was a problem hiding this comment.
Thanks for this! Tricky one to find
Contributor
|
Is the number 1073741824 based off of what you needed for the ropsten block to be processed, or can a smaller number be used? If this is bytes, then that'd be a gig right? |
Contributor
Author
That number is just for my test :) maxReceivedFrameSize and max ReceivedMessageSize are based off bytes. |
Contributor
|
okay, great thanks! |
micahriggan
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's web3 provider issue when rpc result is too big it fails to keep connection (especially WS provider)
For example,
For this issue, we can pass Web3 constructor's options when initiate Web3.

I edited small amount of codes which can allow web3 can have options.
Now we can append options to Web3 like below.
FYI, here's my original issue #2735
And here's web3 issue about clientConfig web3/web3.js#1217 (comment)
Always, thank you @micahriggan :)