Skip to content

[BCN] DRY the doge and ltc p2p classes #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kajoseph merged 1 commit into from
Apr 30, 2025
Merged

[BCN] DRY the doge and ltc p2p classes #3892

kajoseph merged 1 commit into from
Apr 30, 2025

Conversation

@kajoseph
Copy link
Collaborator

@kajoseph kajoseph commented Apr 22, 2025

This PR:

  • Removes duplicate code for the DOGE and LTC p2p.ts classes in favor of class inheritance.

@kajoseph kajoseph requested review from MichaelAJay and leolambo and removed request for MichaelAJay April 29, 2025 14:03
leolambo
leolambo approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@leolambo leolambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kajoseph kajoseph merged commit de685da into bitpay:master Apr 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitsujlangston nitsujlangston nitsujlangston approved these changes

+1 more reviewer

@leolambo leolambo leolambo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kajoseph @nitsujlangston @leolambo