Guidepoint: Enhancement - Clear cookies after sign out#2051
Merged
JohnathanWhite merged 2 commits intobitpay:masterfrom Mar 4, 2026
Merged
Guidepoint: Enhancement - Clear cookies after sign out#2051JohnathanWhite merged 2 commits intobitpay:masterfrom
JohnathanWhite merged 2 commits intobitpay:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a logout-time cookie cleanup to ensure BitPay ID sign-out clears web/session cookies across platforms.
Changes:
- Add
@preeternal/react-native-cookie-managerdependency (JS + iOS pods). - Introduce
clearAllCookiesEverywhere()utility to clear cookie stores on iOS/Android. - Invoke cookie clearing as part of
startDisconnectBitPayIdlogout flow.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/utils/cookieAuth.ts |
New cross-platform cookie clearing helper. |
src/store/bitpay-id/bitpay-id.effects.ts |
Calls cookie clearing during BitPay ID disconnect/logout. |
package.json |
Adds cookie manager dependency (and minor dependency ordering changes). |
yarn.lock |
Locks the new cookie manager package version. |
ios/Podfile.lock |
Adds the CookieManager pod for iOS builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmgustavo
force-pushed
the
guidepoint/feat/android-cookies-01
branch
from
1945aec to
0fc9fee
Compare
| try { | ||
| await clearAllCookiesEverywhere(); | ||
| } catch (err) { | ||
| logManager.debug('An error occured while clearing cookies.'); |
Collaborator
There was a problem hiding this comment.
would use logManager.error instead of debug
Member
Author
There was a problem hiding this comment.
I think that it's not an error that avoid the app continue running normally, and also it's not important for all the most users. Maybe the text is not correct in this case, but the other try/catch are using debug instead error.
cmgustavo
force-pushed
the
guidepoint/feat/android-cookies-01
branch
from
0fc9fee to
0e4a700
Compare
cmgustavo
force-pushed
the
guidepoint/feat/android-cookies-01
branch
from
0e4a700 to
8ca086e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GP-16