Security: Fix untrusted input vulnerability in release workflow - 8.0.x #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security Fix: Prevent Command Injection in Release Workflow
Summary
This PR fixes a command injection vulnerability in the GitHub Actions release workflow by moving all untrusted inputs and GitHub context variables to environment variables.
Problem
The workflow was directly interpolating user inputs and GitHub context variables into shell commands, which could allow command injection attacks. Specifically:
${{ github.event.inputs.bump }}- User-controlled workflow input${{ github.event.inputs.overview }}- User-controlled workflow input${{ github.ref_name }}- GitHub context variable${{ github.repository }}- GitHub context variable${{ steps.version.outputs.version }}- Step output used in shell commands${{ steps.release_data.outputs.title }}- Step output used in shell commands${{ steps.release_data.outputs.body }}- Step output used in shell commandsSolution
All potentially untrusted values are now passed through environment variables before being used in shell commands. This ensures they are treated as literal strings rather than being evaluated as code.
Changes made:
BUMP_TYPEandREF_NAMEto env varsRELEASE_OVERVIEW,REF_NAME, andREPOSITORYto env varsVERSIONandRELEASE_NOTESto env varsVERSIONto env varRELEASE_TITLEandRELEASE_BODYto env varsSecurity Impact
This follows the security best practices outlined in the GitHub Security Lab advisory and prevents potential command injection through GitHub Actions expressions.
Testing