Skip to content
This repository was archived by the owner on Jan 22, 2021. It is now read-only.

Updated PHP requirement to 5.4 #113

Merged
JoshuaEstes merged 1 commit into from
Nov 19, 2014
Merged

Updated PHP requirement to 5.4 #113

JoshuaEstes merged 1 commit into from
Nov 19, 2014

Conversation

@samuelbohler
Copy link
Contributor

@samuelbohler samuelbohler commented Nov 19, 2014

No description provided.

@samuelbohler samuelbohler mentioned this pull request Nov 19, 2014
Closed
@JoshuaEstes
Copy link
Contributor

JoshuaEstes commented Nov 19, 2014 

1) Bitpay\Crypto\McryptExtensionTest::testEncryptAndDecrypt
Failed asserting that '0' is not equal to <string:0>.
/home/travis/build/bitpay/php-bitpay-client/tests/Bitpay/Crypto/McryptExtensionTest.php:36

Leaving this here and rerunning the test again, this might be some random issue that happens every once and awhile

@JoshuaEstes
Copy link
Contributor

JoshuaEstes commented Nov 19, 2014

@sambohler It might also be worth updating the README.md to have a requirements section at the top outlining some of the things in composer.json along with this requirement.

JoshuaEstes added a commit that referenced this pull request Nov 19, 2014
@JoshuaEstes
Merge pull request #113 from sambohler/master
897ffcc 
Updated PHP requirement to 5.4
@JoshuaEstes JoshuaEstes merged commit 897ffcc into bitpay:master Nov 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuelbohler @JoshuaEstes