This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Namespaced class name references/ Custom HTTP Accept Version Header #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. is_a function is now returning false unless the class name is given with the namespace reference. 2. X-Accept-Version needs to be 2.0.0, referring to the API version and not the plugin version.
kleetus
force-pushed
the
bug/namespaces
branch
2 times, most recently
from
64c4b0b to
63bd1a6
Compare
Contributor
|
Tested on fresh setup. Looks good to me. Ready to be merged. |
dantebronto
added a commit
that referenced
this pull request
Nov 17, 2015
Namespaced class name references/ Custom HTTP Accept Version Header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the namespace reference.
not the plugin version.