This repository was archived by the owner on Jan 22, 2021. It is now read-only.
Bug/field types #181
Merged
Bug/field types #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2016 12:44
- Please note that the integration tests won't work with Symfony 3 due to Behat not supporting this version yet. - Unit tests are function with both Symfony 2.x or 3.0
- Model classes will/should test types on mutators, a sane model is calling is_numeric followed by floatval for float types Rationale: Instantiators of models should take care to construct fields of the appropriate type, but model's should have a bit of checking as well for safety.
Contributor
|
LGTM |
|
Having problems with downloading a new version with composer. Looks like packagist was not updated. Could you please update it? packagist: bitpay/php-client |
Contributor
Author
|
I've updated packagist for v2.2.11, it normally works off the webhook, but not this last time. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #180
checks api value as numeric (string or not), then casts to float. This should not be a breaking api change.