Skip to content

Fix token walletName automatically updates#10419

Merged
matiu merged 1 commit intobitpay:masterfrom
justinkook:fix/tokenWalletName
Dec 11, 2019
Merged

Fix token walletName automatically updates#10419
matiu merged 1 commit intobitpay:masterfrom
justinkook:fix/tokenWalletName

Conversation

@justinkook
Copy link
Contributor

  • Get correct token Wallet using token walletId to update walletName

rastajpa
rastajpa previously approved these changes Dec 11, 2019
Copy link
Contributor

@rastajpa rastajpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ACK

@rastajpa
Copy link
Contributor

Tests needs to be fixed

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #10419 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10419      +/-   ##
==========================================
- Coverage   44.02%   44.01%   -0.02%     
==========================================
  Files         172      172              
  Lines       15858    15862       +4     
  Branches     2188     2189       +1     
==========================================
  Hits         6982     6982              
- Misses       8442     8446       +4     
  Partials      434      434
Impacted Files Coverage Δ
src/providers/profile/profile.ts 52.94% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6bf43...d05c0d0. Read the comment docs.

@matiu matiu merged commit c9d06ad into bitpay:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants