Skip to content

Fix: coin icons in contacts from addressbook #11906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmgustavo merged 1 commit into from
Sep 30, 2021
Merged

Fix: coin icons in contacts from addressbook #11906

cmgustavo merged 1 commit into from
Sep 30, 2021

Conversation

@Gamboster
Copy link
Collaborator

@Gamboster Gamboster commented Sep 28, 2021 •
edited
Loading

Screen Shot 2021-09-28 at 16 43 29

rastajpa
rastajpa approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@rastajpa rastajpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@codecov
Copy link

codecov bot commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #11906 (5a48f3f) into master (a8f4fef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11906   +/-   ##
=======================================
  Coverage   28.56%   28.56%           
=======================================
  Files         245      245           
  Lines       22085    22085           
  Branches     3593     3593           
=======================================
  Hits         6309     6309           
  Misses      15222    15222           
  Partials      554      554

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f4fef...5a48f3f. Read the comment docs.

cmgustavo
cmgustavo approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmgustavo cmgustavo merged commit 4717c0c into bitpay:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmgustavo cmgustavo cmgustavo approved these changes

+1 more reviewer

@rastajpa rastajpa rastajpa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gamboster @cmgustavo @rastajpa