Chore/packages: update dependencies due to "npm audit" suggestions#9394
Merged
gabrielbazan7 merged 23 commits intobitpay:masterfrom Dec 18, 2018
Merged
Chore/packages: update dependencies due to "npm audit" suggestions#9394gabrielbazan7 merged 23 commits intobitpay:masterfrom
gabrielbazan7 merged 23 commits intobitpay:masterfrom
Conversation
cmgustavo
force-pushed
the
chore/packages-01
branch
from
df94cd1 to
8c60927
Compare
Codecov Report
@@ Coverage Diff @@
## master #9394 +/- ##
==========================================
+ Coverage 38.19% 38.21% +0.01%
==========================================
Files 162 162
Lines 14608 14608
Branches 1969 1969
==========================================
+ Hits 5580 5582 +2
+ Misses 8765 8763 -2
Partials 263 263
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #9394 +/- ##
==========================================
+ Coverage 38.19% 38.21% +0.01%
==========================================
Files 162 162
Lines 14608 14608
Branches 1969 1969
==========================================
+ Hits 5580 5582 +2
+ Misses 8765 8763 -2
Partials 263 263
Continue to review full report at Codecov.
|
cmgustavo
changed the title
Gamboster
reviewed
Dec 17, 2018
src/pages/send/send.spec.ts
Outdated
| const amount = '1.00000'; | ||
| const coin = Coin.BCH; | ||
| spyOn(navParams, 'get').and.returnValues(amount, coin); | ||
| spyOn(instance.navParams, 'data').and.returnValues(amount, coin); |
Collaborator
There was a problem hiding this comment.
I think this line is not necessary. You could remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to fix "severity vulnerability" with
npm auditplist(forked) andxmlbuilderdependencies for: https://github.com/cmgustavo/cordova-custom-configfound 1 low severity vulnerability in 54571 scanned packagesShould be deployed: apache/cordova-cli@2aca200