[IN-1659] Update openjdk from 8 to 11#311
Conversation
fehersanyi-bitrise
requested review from
Kanan-Bitrise,
bitrise-tom,
bitrisekristof,
lmesz-bitrise and
peterheja-bitrise
as code owners
lmesz-bitrise
left a comment
lmesz-bitrise
left a comment
There was a problem hiding this comment.
How will we validate this change?
fehersanyi-bitrise
dismissed stale reviews from bitrise-tom, lmesz-bitrise, and peterheja-bitrise
via
fd3d8ed
| # ------------------------------------------------------ | ||
| # --- Install Android SDKs and other build packages | ||
|
|
||
| ENV SDKMANAGER_PATH /opt/android-sdk-linux/cmdline-tools/tools/bin/sdkmanager |
There was a problem hiding this comment.
Please add it to the PATH? It will be a problem for the customer too if they won't be able to use sdkmanager.
There was a problem hiding this comment.
it is on path, it is just a make sure it is there because on mac I had to deal with crap so I'm now super explicit kind of movement 🧐
There was a problem hiding this comment.
If it is on the path then this step is unnecessary.
I am afraid if it does not work with PATH the reason is that it is another sdkmanager with different settings which can be resulted to install to not proper places
There was a problem hiding this comment.
Yep, it is possible. At the time of introducing commandline-tools (#300) it needs to be located in the very specific location relative to $ANDROID_HOME.
Even after updating commandline-tools using sdkmanager provided by themselves, the new version was installed in a different location resulting in 2 sdk managers.
Maybe @fehersanyi-bitrise encountered something similar.
| RUN dpkg --add-architecture i386 | ||
| RUN apt-get update -qq | ||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y openjdk-8-jdk libc6:i386 libstdc++6:i386 libgcc1:i386 libncurses5:i386 libz1:i386 net-tools | ||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y openjdk-8-jdk openjdk-11-jdk libc6:i386 libstdc++6:i386 libgcc1:i386 libncurses5:i386 libz1:i386 net-tools |
There was a problem hiding this comment.
Don't we need to remove openjdk-8-jdk?
| RUN dpkg --add-architecture i386 | ||
| RUN apt-get update -qq | ||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y openjdk-8-jdk libc6:i386 libstdc++6:i386 libgcc1:i386 libncurses5:i386 libz1:i386 net-tools | ||
| RUN DEBIAN_FRONTEND=noninteractive apt-get install -y openjdk-8-jdk openjdk-11-jdk libc6:i386 libstdc++6:i386 libgcc1:i386 libncurses5:i386 libz1:i386 net-tools |
This reverts commit c2ce84f.
6 participants
Pull Request Checklist
Check/accept these:
are not updated, so if the tool requires frequent updates you should handle the installation on-demand (see: Install Any Additional Tool - DevCenter for more information)
system_report.shfor the new tool(s) I addedCopy or link the tool's changelog here