This repository was archived by the owner on Mar 31, 2022. It is now read-only.
SDK tools, Platform Tools and Emulator versions added to system_report.sh#96
Merged
viktorbenei merged 2 commits intobitrise-io:masterfrom Jul 14, 2017
Merged
Conversation
viktorbenei
suggested changes
Jul 13, 2017
system_report.sh
Outdated
| else | ||
| ver_line="$(grep ^Pkg.Revision ${ANDROID_HOME}/tools/source.properties | cut -d= -f 2)" ; echo "* SDK Tools version: $ver_line" | ||
| ver_line="$(grep ^Pkg.Revision ${ANDROID_HOME}/platform-tools/source.properties | cut -d= -f 2)" ; echo "* Platform Tools version: $ver_line" | ||
| ver_line="$(grep ^Pkg.Revision ${ANDROID_HOME}/emulator/source.properties | cut -d= -f 2)" ; echo "* Emulator version: $ver_line" |
Contributor
There was a problem hiding this comment.
From the PR check for this line:
grep: /opt/android-sdk-linux/emulator/source.properties: No such file or directory
* Emulator version:
Contributor
There was a problem hiding this comment.
if possible please also make this line fail (non 0 exit code) in case of an error
Contributor
Author
There was a problem hiding this comment.
OK, will do.
It seems that emulator is no longer preinstalled with tools and needs to be installed explicitly by sdkmanager in Dockerfile.
make emulator, platform tools and sdk tools version checks failing if there is component found
viktorbenei
approved these changes
Jul 14, 2017
Contributor
viktorbenei
left a comment
viktorbenei
left a comment
There was a problem hiding this comment.
Awesome, thank you @koral-- !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.