Skip to content

Error log updated for: #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Error log updated for: #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eca216
Error log updated for:
BirmacherAkos May 25, 2018
b63a6fe
PR clean - fix (+1 squashed commit)
BirmacherAkos May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions codesigndoc/codesigndoc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package codesigndoc

import (
"errors"
"fmt"
"os"

"github.com/bitrise-io/go-utils/colorstring"

"github.com/bitrise-io/go-utils/command"
"github.com/bitrise-io/go-utils/log"
"github.com/bitrise-io/goinp/goinp"
Expand Down Expand Up @@ -72,7 +73,10 @@ func ExportCodesignFiles(archivePath, outputDirPath string, certificatesOnly boo
}

if len(ipaExportCodeSignGroups) == 0 {
return false, false, errors.New("no ipa export code sign groups collected")
errorString := "\n🚨 " + colorstring.Red("Failed to collect codesigning files for the selected distribution type.\n") +
colorstring.Yellow("Export an ipa with the same export method which code signing files you want to collect (e.g app-store if you want to collect the code signing files for app-store distribution) in your local xcode and run codesigndoc again.\n") +
colorstring.Yellow("If the tool fails please report the issue with the codesigndoc log and the local ipa exportOptions.plist")
return false, false, fmt.Errorf(errorString)
}

codeSignGroups := append(ipaExportCodeSignGroups, archiveCodeSignGroup)
Expand Down
3 changes: 2 additions & 1 deletion codesigndoc/codesigngroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ func collectIpaExportCodeSignGroups(archive xcarchive.IosArchive, installedCerti

if len(filteredCodeSignGroups) == 0 {
fmt.Println()
log.Errorf(collectCodesigningFilesInfo)
log.Errorf("🚨 Could not find the codesigning files for %s ipa export:", selectedExportMethod)
log.Warnf(collectCodesigningFilesInfo)
fmt.Println()
fmt.Println()
question := "Do you want to collect another ipa export code sign files"
Expand Down